Support legacy CSP enum compatibility - #350
Merged
Merged
Conversation
Signed-off-by: Shivam Malhotra <shivam.malhotra@cubistsystematic.com>
malhotrashivam
marked this pull request as ready for review
September 4, 2026 14:36
malhotrashivam
requested review from
arhamchopra,
emilybarrettp72,
feussy,
hintse,
ptomecek,
timkpaine and
vstolin
as code owners
September 4, 2026 14:36
Contributor
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #350 +/- ##
==========================================
+ Coverage 86.83% 86.94% +0.11%
==========================================
Files 158 159 +1
Lines 18714 18834 +120
Branches 1768 1774 +6
==========================================
+ Hits 16250 16376 +126
+ Misses 2464 2458 -6 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Signed-off-by: Shivam Malhotra <shivam.malhotra@cubistsystematic.com>
malhotrashivam
marked this pull request as draft
September 4, 2026 20:27
Signed-off-by: Shivam Malhotra <shivam.malhotra@cubistsystematic.com>
A whole-basket send channel on an enum-keyed dict basket never worked. Legacy CSP enums were not recognized as a basket key type, so the basket was built with no shape, and the key expansion inserted into _send_channels while that dict was being iterated. Recognize both enum flavors and snapshot the items first. psp_flatten dropped CSP enum values to the empty string; report the member name the way the schema already promises. Unwrap Optional around an annotated array field so its element type still resolves. Keep the filter module importable without CSP, while still surfacing an import error from a CSP install that is present but broken. Signed-off-by: Tim Paine <3105306+timkpaine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #322.
Related CSP enum change: Point72/csp#743
Validation:
make lint-py