ENH: Add C++ from_dict and from_json methods for csp.Struct - #758
Open
aadya940 wants to merge 3 commits into
Open
ENH: Add C++ from_dict and from_json methods for csp.Struct#758aadya940 wants to merge 3 commits into
from_dict and from_json methods for csp.Struct#758aadya940 wants to merge 3 commits into
Conversation
aadya940
requested review from
AdamGlustein,
alexddobkin,
arhamchopra,
ptomecek,
robambalu,
svatasoiu and
timkpaine
as code owners
September 6, 2026 09:01
…cases which may not be supported Signed-off-by: Aadya Chinubhai <aadyachinubhai@gmail.com>
Signed-off-by: Aadya Chinubhai <aadyachinubhai@gmail.com>
aadya940
force-pushed
the
from_methods_cpp
branch
from
September 6, 2026 09:02
1541ab0 to
90ffa10
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #518
This change replaces
from_dict's pure Python implementation with a C++ one, and adds a newfrom_jsonmethod to build acsp.Structdirectly from a JSON string.from_jsonparses with rapidjson and writes into the struct fields, with a template specialization per type.from_dictis much simpler sincefromPythonalready exists.The speedup is between
11-12xfor both of them!NOTES:
Not every struct can take the C++ path.
StructMetaonly keeps normalized field types, so annotations likeLiteral[1,2,3]orDict[str, SomeEnum]are removed before C++ can see them and the values cannot be reconstructed. Those structs keep using the Python implementation, this is pre-decided per class.from_jsonis stricter thanfrom_dicthere since JSON can't carry Python objects at all.