small test fixes

Signed-off-by: Tim Paine <3105306+timkpaine@users.noreply.github.com>

Author: timkpaine

polars_io_tools/io_sources/util.py

@@ -163,6 +163,9 @@ def _storage_options_for(cache_uri: str, aws_profile: str | None = None) -> Stor
         cred_opts = credential_provider._storage_update_options()
         endpoint = cred_opts.get("endpoint_url")
 
+    if endpoint:
+        endpoint = _resolve_endpoint_hostname(endpoint)
+
     # Set endpoint in both option dicts with appropriate keys
     if endpoint:
         pyarrow_opts["endpoint_override"] = endpoint

polars_io_tools/tests/io_sources/test_util.py

@@ -1076,7 +1076,7 @@ def test_resolve_hostname_with_port(self, monkeypatch):
         """Test resolving hostname to IP when endpoint has a port."""
         monkeypatch.setattr("socket.gethostbyname", lambda hostname: "10.1.2.3")
 
-        result = _resolve_endpoint_hostname("http://:9020")
+        result = _resolve_endpoint_hostname("http://grid:9020")
 
         assert result == "http://10.1.2.3:9020"
 
@@ -1108,7 +1108,7 @@ def test_resolve_hostname_with_path(self, monkeypatch):
         """Test that paths are preserved in the resolved URL."""
         monkeypatch.setattr("socket.gethostbyname", lambda hostname: "10.1.2.3")
 
-        result = _resolve_endpoint_hostname("http://:9020/some/path")
+        result = _resolve_endpoint_hostname("http://grid:9020/some/path")
 
         assert result == "http://10.1.2.3:9020/some/path"
 
@@ -1157,9 +1157,9 @@ def capture_gethostbyname(hostname):
 
         monkeypatch.setattr("socket.gethostbyname", capture_gethostbyname)
 
-        _resolve_endpoint_hostname("http://:9020")
+        _resolve_endpoint_hostname("http://grid:9020")
 
-        assert captured_hostname["value"] == ""
+        assert captured_hostname["value"] == "grid"
 
     def test_storage_options_resolution_failure_keeps_original(self, monkeypatch, caplog):
         """Test that DNS resolution failure in _storage_options_for keeps the original endpoint."""
@@ -1190,11 +1190,11 @@ def failing_gethostbyname(hostname):
         monkeypatch.setattr("boto3.Session", FakeSession)
         monkeypatch.setattr("polars_io_tools.io_sources.util.pl.CredentialProviderAWS", FakeCredentialProvider, raising=False)
         monkeypatch.setattr("socket.gethostbyname", failing_gethostbyname)
-        monkeypatch.setenv("AWS_ENDPOINT_URL", "http://:9020")
+        monkeypatch.setenv("AWS_ENDPOINT_URL", "http://grid:9020")
 
         opts = _storage_options_for("s3://bucket/path")
 
         # Endpoint should be kept as original due to resolution failure
-        assert opts.pyarrow["endpoint_override"] == "http://:9020"
-        assert opts.polars["endpoint_url"] == "http://:9020"
+        assert opts.pyarrow["endpoint_override"] == "http://grid:9020"
+        assert opts.polars["endpoint_url"] == "http://grid:9020"
         assert "Failed to resolve hostname" in caplog.text