Rename multi_source to pushdown_combine - #16
Merged
Conversation
The name `multi_source` described the inputs (multiple sources) rather than what the function does. Its defining feature is coordinated predicate pushdown into a user-supplied `combine` function; the multi-source aspect is incidental. Rename to `pushdown_combine` to name the behavior, consistent with polars/polars-io-tools naming. - Move io_sources/multi_source.py -> pushdown_combine.py - Move tests/io_sources/test_multi_source.py -> test_pushdown_combine.py - Update the function, __all__, imports, test class names, and docs - FilterSpec is unchanged Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: Pascal Tomecek <40371786+ptomecek@users.noreply.github.com>
ptomecek
force-pushed
the
chore/rename-multi-source-to-pushdown-combine
branch
from
August 19, 2026 21:29
31adfdd to
eb906c1
Compare
timkpaine
approved these changes
Aug 19, 2026
Contributor
Test Results1 378 tests ±0 1 330 ✅ ±0 30s ⏱️ -7s Results for commit eb906c1. ± Comparison against base commit 3b2ef21. This pull request removes 95 and adds 95 tests. Note that renamed tests count towards both. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Renames the
multi_sourceAPI topushdown_combine.Why
multi_sourcenamed the inputs (multiple sources). The function's defining feature is coordinated predicate pushdown into a user-suppliedcombinefunction — the multi-source aspect is incidental.pushdown_combinenames the behavior, in keeping with polars / polars-io-tools naming conventions.Changes
io_sources/multi_source.py→pushdown_combine.pytests/io_sources/test_multi_source.py→test_pushdown_combine.py__all__, all imports, and test class names (TestMultiSource*→TestPushdownCombine*)FilterSpecis unchangedVerification
Full related test suite passes (152 passed). Top-level
polars_io_tools.pushdown_combineis exported;multi_sourceis fully removed.