Skip to content

Commit 457211b

Browse files
programgamesclaude
andcommitted
feat: fallback female sprites to their default counterparts for female-only pokemon
For pokemon whose species has gender_rate=8 (exclusively female), fill the null female sprite keys with their default counterparts across all sprite sections. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
1 parent c40a25c commit 457211b

2 files changed

Lines changed: 50 additions & 2 deletions

File tree

‎pokemon_v2/serializers.py‎

Lines changed: 30 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
from __future__ import annotations
44

55
import itertools
6+
import json
67
from typing import TYPE_CHECKING, Any, ClassVar, Protocol, cast
78

89
from django.db.models import Q
@@ -2933,10 +2934,37 @@ class Meta:
29332934
"past_types",
29342935
)
29352936

2937+
_FEMALE_FALLBACKS: ClassVar[dict[str, str]] = {
2938+
"front_female": "front_default",
2939+
"back_female": "back_default",
2940+
"front_shiny_female": "front_shiny",
2941+
"back_shiny_female": "back_shiny",
2942+
}
2943+
29362944
@extend_schema_field(PokemonSpritesSerializer)
2937-
def get_pokemon_sprites(self, obj: Pokemon) -> dict[str, str | None]:
2945+
def get_pokemon_sprites(self, obj: Pokemon) -> dict[str, str | None] | str:
29382946
sprites_list = list(cast("PokemonWithRelations", obj).pokemonsprites.all())
2939-
return sprites_list[0].sprites if sprites_list else {}
2947+
if not sprites_list:
2948+
return {}
2949+
sprites: Any = sprites_list[0].sprites
2950+
if obj.pokemon_species is None or obj.pokemon_species.gender_rate != 8:
2951+
return sprites
2952+
if isinstance(sprites, str):
2953+
parsed = json.loads(sprites)
2954+
self._fill_female_sprites(parsed)
2955+
return json.dumps(parsed)
2956+
self._fill_female_sprites(sprites)
2957+
return sprites
2958+
2959+
def _fill_female_sprites(self, node: object) -> None:
2960+
if not isinstance(node, dict):
2961+
return
2962+
sprites = cast("dict[str, Any]", node)
2963+
for female_key, default_key in self._FEMALE_FALLBACKS.items():
2964+
if female_key in sprites and sprites[female_key] is None and sprites.get(default_key) is not None:
2965+
sprites[female_key] = sprites[default_key]
2966+
for value in sprites.values():
2967+
self._fill_female_sprites(value)
29402968

29412969
@extend_schema_field(PokemonCriesSerializer)
29422970
def get_pokemon_cries(self, obj: Pokemon) -> dict[str, str | None]:

‎pokemon_v2/tests.py‎

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4649,6 +4649,26 @@ def test_pokemon_moves_version_group_details_are_deterministically_ordered(self)
46494649
[1, 2, 3],
46504650
)
46514651

4652+
def test_pokemon_api_female_only_sprites_fallback(self):
4653+
pokemon_species = self.setup_pokemon_species_data(name="female only pkmn spcs", gender_rate=8)
4654+
pokemon = self.setup_pokemon_data(pokemon_species=pokemon_species, name="female only pkmn")
4655+
self.setup_pokemon_form_data(pokemon=pokemon, name="female only pkmn form")
4656+
self.setup_pokemon_sprites_data(pokemon=pokemon, front_default=True, front_female=False)
4657+
self.setup_pokemon_cries_data(pokemon, latest=True, legacy=True)
4658+
4659+
response = self.client.get("{}/pokemon/{}/".format(API_V2, pokemon.pk), headers={"host": "testserver"})
4660+
4661+
self.assertEqual(response.status_code, status.HTTP_200_OK)
4662+
4663+
response_sprites = json.loads(response.data["sprites"])
4664+
4665+
self.assertIsNotNone(response_sprites["front_default"])
4666+
self.assertEqual(response_sprites["front_female"], response_sprites["front_default"])
4667+
self.assertEqual(
4668+
response_sprites["other"]["showdown"]["front_female"],
4669+
response_sprites["other"]["showdown"]["front_default"],
4670+
)
4671+
46524672
def test_pokemon_form_api(self):
46534673
pokemon_species = self.setup_pokemon_species_data()
46544674
pokemon = self.setup_pokemon_data(pokemon_species=pokemon_species)

0 commit comments

Comments
 (0)