feat: factor pc keyboard into a dedicated module, shift pc keys along config.piano_range() - #416
Closed
kasimeka wants to merge 2 commits into
Closed
feat: factor pc keyboard into a dedicated module, shift pc keys along config.piano_range()#416kasimeka wants to merge 2 commits into
config.piano_range()#416kasimeka wants to merge 2 commits into
Conversation
kasimeka
marked this pull request as ready for review
August 4, 2026 07:53
Contributor
Author
|
unrelated, but i use a dvorak keyboard and may work on a system for changing layouts to add dvorak support |
Owner
|
#417 can you check if this works correctly with dvorak? (assuming you are using a software defined keyboard layout, not with actual hardware devorak) |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #415
i manage my dev environments with nix, hence the nix flake included in this PR. if you'd like i can post it in a separate PR or drop it completely.