feat(pc-keyboard): Octave shift on z/x press & layout independent key handling - #417
Conversation
|
this makes a lot more sense in the context of the repo and i feel like an idiot for my PR😅 |
|
can i get my nix flake merged tho? would love to run the app with |
|
any intention to implement the guess an octave shift near the center of the piano range logic tho? |
No problem, it still makes the implementation easier for me when I have a POC to go of off.
Sure, that might be useful for other people too.
Yeah, I just wonder how to do that best in the context of me adding the "remember last setting" logic. Perhaps the remember logic is not that usefull tho. |
i think overwriting the saved octave shift with the calculated value only after piano range settings are changed, and otherwise keeping the saved value intact would be reasonable |
Sounds good. I will recalculate it on every range change. |
Uh oh!
There was an error while loading. Please reload this page.