Skip to content

wasm: sanitize title contents #331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mcginty wants to merge 1 commit into
base: master
Choose a base branch
from
Open

wasm: sanitize title contents #331

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
- Add `FileDialog::set_show_hidden_files` and `AsyncFileDialog::set_show_hidden_files` to control hidden file visibility. Supported on macOS, Windows, and Linux (GTK3).
- Honor `FileDialog::set_directory` and `AsyncFileDialog::set_directory` when using the zenity fallback backend on Linux.
- Fix `liblary` typo in docs
- Change wasm title to sanitize text contents via `title_el.set_text_content()` rather than `title_el.set_inner_html()`.

## 0.17.2

Expand Down
2 changes: 1 addition & 1 deletion src/backend/wasm.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ impl<'a> WasmDialog<'a> {
let title_el: HtmlElement = document.create_element("div").unwrap().dyn_into().unwrap();

title_el.set_id("rfd-title");
title_el.set_inner_html(title);
title_el.set_text_content(Some(title));

card.append_child(&title_el).unwrap();
title_el
Expand Down