Skip to content

fix: add polling interval to download progress loop #306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
starry-shivam merged 1 commit into from
Aug 1, 2026
+2 −0
Merged

fix: add polling interval to download progress loop #306

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions app/src/main/java/com/starry/myne/helpers/book/BookDownloader.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ class BookDownloader(private val context: Context) {
const val BOOKS_FOLDER = "ebooks"
const val TEMP_FOLDER = "temp_books"
private const val MAX_FILENAME_LENGTH = 100
private const val DOWNLOAD_POLL_INTERVAL_MS = 250L

/**
* Sanitizes book title by replacing forbidden chars which are not allowed
Expand Down Expand Up @@ -195,6 +196,7 @@ class BookDownloader(private val context: Context) {
downloadProgressListener(progress, status)
runningDownloads[book.id]?.progress?.value = progress
cursor.close()
if (!isDownloadFinished) delay(DOWNLOAD_POLL_INTERVAL_MS)
}
/**
Remove download from running downloads when loop ends.
Expand Down
Loading