fix(logs_alert): read destinations from the alert, not their own endpoint

PostHog #84509 dropped the separate destinations list endpoint and returns
the same groups on the alert read instead. A GET to the destinations path
now answers 405, so refresh and import would fail against the deployed API.

The list is a field on the alert, so it is not paginated. That removes the
listAllWithStatus helper this branch added for it.

Author: vdekrijger

docs/resources/logs_alert_destination.md

@@ -5,7 +5,7 @@ subcategory: ""
 description: |-
   Manage where a log alert https://posthog.com/docs/logs/alerts sends its notifications. A posthog_logs_alert with no destination still evaluates and reports its state, but notifies nobody.
   ~> Every attribute forces replacement. PostHog has no update endpoint for destinations, so changing a channel or a URL destroys the destination and creates a new one. There is a short window during the apply where the alert has no destination and would notify nobody if it fired.
-  Each resource represents one user-visible destination. PostHog implements that destination as a group of hog functions, one per alert transition (firing, resolved, errored, auto-disabled), sharing the configuration below. The group has no id of its own, so this resource's id is the group's hog_function_ids, sorted and joined by commas. Those hog functions are owned by the alert: posthog_hog_function cannot create, update, or delete them. Terraform reads, creates, and deletes each managed group through the alert's dedicated destinations API.
+  Each resource represents one user-visible destination. PostHog implements that destination as a group of hog functions, one per alert transition (firing, resolved, errored, auto-disabled), sharing the configuration below. The group has no id of its own, so this resource's id is the group's hog_function_ids, sorted and joined by commas. Those hog functions are owned by the alert: posthog_hog_function cannot create, update, or delete them. Terraform creates and deletes each managed group through the alert's destinations API, and reads it back from the alert itself.
 ---
 
 # posthog_logs_alert_destination (Resource)
@@ -14,7 +14,7 @@ Manage where a [log alert](https://posthog.com/docs/logs/alerts) sends its notif
 
 ~> **Every attribute forces replacement.** PostHog has no update endpoint for destinations, so changing a channel or a URL destroys the destination and creates a new one. There is a short window during the apply where the alert has no destination and would notify nobody if it fired.
 
-Each resource represents one user-visible destination. PostHog implements that destination as a group of hog functions, one per alert transition (firing, resolved, errored, auto-disabled), sharing the configuration below. The group has no id of its own, so this resource's `id` is the group's `hog_function_ids`, sorted and joined by commas. Those hog functions are owned by the alert: `posthog_hog_function` cannot create, update, or delete them. Terraform reads, creates, and deletes each managed group through the alert's dedicated destinations API.
+Each resource represents one user-visible destination. PostHog implements that destination as a group of hog functions, one per alert transition (firing, resolved, errored, auto-disabled), sharing the configuration below. The group has no id of its own, so this resource's `id` is the group's `hog_function_ids`, sorted and joined by commas. Those hog functions are owned by the alert: `posthog_hog_function` cannot create, update, or delete them. Terraform creates and deletes each managed group through the alert's destinations API, and reads it back from the alert itself.
 
 ## Example Usage
 

internal/httpclient/client.go

@@ -211,20 +211,13 @@ func doDelete(c *PosthogClient, ctx context.Context, path string) (HTTPStatusCod
 
 // listAll fetches all pages from a paginated endpoint, following Next links until exhausted.
 func listAll[T any](c *PosthogClient, ctx context.Context, initialPath string) ([]T, error) {
-	all, _, err := listAllWithStatus[T](c, ctx, initialPath)
-	return all, err
-}
-
-func listAllWithStatus[T any](c *PosthogClient, ctx context.Context, initialPath string) ([]T, HTTPStatusCode, error) {
 	var all []T
-	var status HTTPStatusCode
 	path := initialPath
 
 	for path != "" {
-		page, pageStatus, err := doGet[PaginatedResponse[T]](c, ctx, path)
-		status = pageStatus
+		page, _, err := doGet[PaginatedResponse[T]](c, ctx, path)
 		if err != nil {
-			return nil, status, err
+			return nil, err
 		}
 
 		all = append(all, page.Results...)
@@ -248,5 +241,5 @@ func listAllWithStatus[T any](c *PosthogClient, ctx context.Context, initialPath
 		}
 	}
 
-	return all, status, nil
+	return all, nil
 }

internal/httpclient/logs_alert_destinations_test.go

@@ -16,27 +16,21 @@ const (
 	testLogsAlertProjectID     = "123"
 	testLogsAlertID            = "019dbe94-cec8-781b-9470-4a970cd69ebf"
 	testLogsAlertDestinationsP = "/api/projects/123/logs/alerts/019dbe94-cec8-781b-9470-4a970cd69ebf/destinations/"
+	testLogsAlertP             = "/api/projects/123/logs/alerts/019dbe94-cec8-781b-9470-4a970cd69ebf/"
 )
 
-func writeDestinationPage(t *testing.T, w http.ResponseWriter, next any, destinations ...LogsAlertDestination) {
+// Destinations are read off the alert itself; PostHog exposes no endpoint that lists
+// them on their own.
+func writeAlertWithDestinations(t *testing.T, w http.ResponseWriter, destinations ...LogsAlertDestination) {
 	t.Helper()
-	writeJSONResponse(t, w, map[string]any{
-		"count":    len(destinations),
-		"next":     next,
-		"previous": nil,
-		"results":  destinations,
-	})
-}
-
-func absoluteNextPageURL(server *httptest.Server, query string) string {
-	return server.URL + testLogsAlertDestinationsP + "?" + query
+	writeJSONResponse(t, w, LogsAlert{ID: testLogsAlertID, Destinations: destinations})
 }
 
 func TestListLogsAlertDestinations_PopulatesOnlyTheFieldsOfEachDestinationType(t *testing.T) {
 	server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
 		assert.Equal(t, http.MethodGet, r.Method)
-		assert.Equal(t, testLogsAlertDestinationsP, r.URL.Path)
-		writeDestinationPage(t, w, nil,
+		assert.Equal(t, testLogsAlertP, r.URL.Path)
+		writeAlertWithDestinations(t, w,
 			LogsAlertDestination{HogFunctionIDs: []string{"hf-2", "hf-1"}, Type: "slack", SlackWorkspaceID: util.Int64Ptr(1), SlackChannelID: util.StringPtr("C0123456789")},
 			LogsAlertDestination{HogFunctionIDs: []string{"hf-3"}, Type: "webhook", RedactedWebhookURL: util.StringPtr("https://example.com/…")},
 		)
@@ -56,33 +50,6 @@ func TestListLogsAlertDestinations_PopulatesOnlyTheFieldsOfEachDestinationType(t
 	assert.Nil(t, destinations[1].SlackChannelID)
 }
 
-func TestListLogsAlertDestinations_ReturnsDestinationsFromEveryPage(t *testing.T) {
-	var server *httptest.Server
-	server = httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
-		assert.Equal(t, testLogsAlertDestinationsP, r.URL.Path)
-
-		if r.URL.Query().Get("offset") == "" {
-			writeDestinationPage(t, w, absoluteNextPageURL(server, "limit=1&offset=1"),
-				LogsAlertDestination{HogFunctionIDs: []string{"hf-1"}, Type: "webhook", RedactedWebhookURL: util.StringPtr("https://first.example.com/…")})
-			return
-		}
-
-		assert.Equal(t, "1", r.URL.Query().Get("offset"))
-		writeDestinationPage(t, w, nil,
-			LogsAlertDestination{HogFunctionIDs: []string{"hf-2"}, Type: "teams", RedactedWebhookURL: util.StringPtr("https://second.example.com/…")})
-	}))
-	defer server.Close()
-
-	client := newTestPosthogClient(server)
-	destinations, status, err := client.ListLogsAlertDestinations(context.Background(), testLogsAlertProjectID, testLogsAlertID)
-
-	require.NoError(t, err)
-	assert.Equal(t, HTTPStatusCode(http.StatusOK), status)
-	require.Len(t, destinations, 2)
-	assert.Equal(t, []string{"hf-1"}, destinations[0].HogFunctionIDs)
-	assert.Equal(t, []string{"hf-2"}, destinations[1].HogFunctionIDs)
-}
-
 func TestCreateLogsAlertDestination_ReturnsOnlyTheNewHogFunctionIDs(t *testing.T) {
 	server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
 		assert.Equal(t, http.MethodPost, r.Method)
@@ -155,7 +122,8 @@ func TestDeleteLogsAlertDestination_SendsTheWholeGroupInOneCall(t *testing.T) {
 }
 
 func TestListLogsAlertDestinations_ReturnsTheNotFoundStatusToTheCaller(t *testing.T) {
-	server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, _ *http.Request) {
+	server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
+		assert.Equal(t, testLogsAlertP, r.URL.Path)
 		w.WriteHeader(http.StatusNotFound)
 	}))
 	defer server.Close()

internal/httpclient/logs_alerts.go

@@ -19,8 +19,11 @@ type LogsAlert struct {
 	ScheduleRestriction *LogsAlertSchedule `json:"schedule_restriction,omitempty"`
 	SnoozeUntil         *string            `json:"snooze_until,omitempty"`
 	State               *string            `json:"state,omitempty"`
-	CreatedAt           *string            `json:"created_at,omitempty"`
-	UpdatedAt           *string            `json:"updated_at,omitempty"`
+	// The alert read carries its destinations. PostHog has no endpoint that lists them
+	// on their own, so this is how a managed destination is refreshed and imported.
+	Destinations []LogsAlertDestination `json:"destinations,omitempty"`
+	CreatedAt    *string                `json:"created_at,omitempty"`
+	UpdatedAt    *string                `json:"updated_at,omitempty"`
 }
 
 type LogsAlertRequest struct {
@@ -106,7 +109,11 @@ func logsAlertDestinationsPath(projectID, alertID string) string {
 }
 
 func (c *PosthogClient) ListLogsAlertDestinations(ctx context.Context, projectID, alertID string) ([]LogsAlertDestination, HTTPStatusCode, error) {
-	return listAllWithStatus[LogsAlertDestination](c, ctx, logsAlertDestinationsPath(projectID, alertID))
+	alert, status, err := c.GetLogsAlert(ctx, projectID, alertID)
+	if err != nil {
+		return nil, status, err
+	}
+	return alert.Destinations, status, nil
 }
 
 func (c *PosthogClient) CreateLogsAlertDestination(ctx context.Context, projectID, alertID string, input LogsAlertDestinationRequest) (LogsAlertDestination, error) {

internal/resource/logs_alert_destination.go

@@ -81,8 +81,8 @@ func (o LogsAlertDestinationOps) Schema() schema.Schema {
 			"(firing, resolved, errored, auto-disabled), sharing the configuration below. The group has no id " +
 			"of its own, so this resource's `id` is the group's `hog_function_ids`, sorted and joined by " +
 			"commas. Those hog functions are owned by the alert: `posthog_hog_function` cannot create, update, or " +
-			"delete them. Terraform reads, creates, and deletes each managed group through the alert's " +
-			"dedicated destinations API.",
+			"delete them. Terraform creates and deletes each managed group through the alert's " +
+			"destinations API, and reads it back from the alert itself.",
 		Attributes: map[string]schema.Attribute{
 			"id": schema.StringAttribute{
 				Computed: true,

internal/resource/logs_alert_destination_test.go

@@ -342,28 +342,22 @@ func destinationInState(id string) LogsAlertDestinationTFModel {
 	}
 }
 
-func writeDestinationPage(t *testing.T, w http.ResponseWriter, next any, destinations ...httpclient.LogsAlertDestination) {
+// Destinations are read off the alert itself; PostHog exposes no endpoint that lists
+// them on their own.
+func writeAlertWithDestinations(t *testing.T, w http.ResponseWriter, destinations ...httpclient.LogsAlertDestination) {
 	t.Helper()
 	w.Header().Set("Content-Type", "application/json")
-	require.NoError(t, json.NewEncoder(w).Encode(map[string]any{
-		"count":    len(destinations),
-		"next":     next,
-		"previous": nil,
-		"results":  destinations,
+	require.NoError(t, json.NewEncoder(w).Encode(httpclient.LogsAlert{
+		ID:           testLogsAlertDestinationAlertID,
+		Destinations: destinations,
 	}))
 }
 
-func TestLogsAlertDestinationRead_FindsADestinationOnALaterPage(t *testing.T) {
-	var server *httptest.Server
-	server = httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
-		require.Equal(t, logsAlertDestinationsPath(), r.URL.Path)
-
-		if r.URL.Query().Get("offset") == "" {
-			writeDestinationPage(t, w, server.URL+logsAlertDestinationsPath()+"?limit=1&offset=1",
-				httpclient.LogsAlertDestination{HogFunctionIDs: []string{"hf-1"}, Type: destinationTypeWebhook})
-			return
-		}
-		writeDestinationPage(t, w, nil,
+func TestLogsAlertDestinationRead_FindsTheGroupAmongTheAlertsDestinations(t *testing.T) {
+	server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
+		require.Equal(t, logsAlertPath(), r.URL.Path)
+		writeAlertWithDestinations(t, w,
+			httpclient.LogsAlertDestination{HogFunctionIDs: []string{"hf-1"}, Type: destinationTypeWebhook},
 			httpclient.LogsAlertDestination{HogFunctionIDs: []string{"hf-2", "hf-3"}, Type: destinationTypeTeams})
 	}))
 	defer server.Close()
@@ -379,8 +373,8 @@ func TestLogsAlertDestinationRead_FindsADestinationOnALaterPage(t *testing.T) {
 
 func TestLogsAlertDestinationRead_ReportsADestinationMissingFromALiveAlertAsDeleted(t *testing.T) {
 	server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
-		require.Equal(t, logsAlertDestinationsPath(), r.URL.Path)
-		writeDestinationPage(t, w, nil,
+		require.Equal(t, logsAlertPath(), r.URL.Path)
+		writeAlertWithDestinations(t, w,
 			httpclient.LogsAlertDestination{HogFunctionIDs: []string{"hf-9"}, Type: destinationTypeWebhook})
 	}))
 	defer server.Close()
@@ -395,8 +389,8 @@ func TestLogsAlertDestinationRead_ReportsADestinationMissingFromALiveAlertAsDele
 
 func TestLogsAlertDestinationRead_RefusesAGroupSplitAcrossConfigurations(t *testing.T) {
 	server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
-		require.Equal(t, logsAlertDestinationsPath(), r.URL.Path)
-		writeDestinationPage(t, w, nil,
+		require.Equal(t, logsAlertPath(), r.URL.Path)
+		writeAlertWithDestinations(t, w,
 			httpclient.LogsAlertDestination{HogFunctionIDs: []string{"hf-1"}, Type: destinationTypeWebhook},
 			httpclient.LogsAlertDestination{HogFunctionIDs: []string{"hf-2"}, Type: destinationTypeWebhook})
 	}))
@@ -411,7 +405,7 @@ func TestLogsAlertDestinationRead_RefusesAGroupSplitAcrossConfigurations(t *test
 
 func TestLogsAlertDestinationRead_RefusesAGroupWidenedWithExtraIDs(t *testing.T) {
 	server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, _ *http.Request) {
-		writeDestinationPage(t, w, nil,
+		writeAlertWithDestinations(t, w,
 			httpclient.LogsAlertDestination{HogFunctionIDs: []string{"hf-1", "hf-2"}, Type: destinationTypeWebhook})
 	}))
 	defer server.Close()