feat(gateway): record a successful mint in the run log - #1179
Open
brandonleung wants to merge 1 commit into
Open
feat(gateway): record a successful mint in the run log#1179brandonleung wants to merge 1 commit into
brandonleung wants to merge 1 commit into
Conversation
Every other branch logs a failure, so a run that minted and one that never reached the mint were indistinguishable. The token is never logged. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
🧙 Wizard CIRun the Wizard CI and test your changes against wizard-workbench example apps by replying with a GitHub comment using one of the following commands: Test all apps:
Test all apps in a directory:
Test an individual app:
Show more apps
Test against a Context Mill branch:
Add Results will be posted here when complete. |
brandonleung
marked this pull request as ready for review
August 31, 2026 22:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
resolveGatewayAuthlogs on every failure and fallback branch but nothing on success, soposthog-wizard.logcannot distinguish a run that minted a scoped token from one that never reached the mint.Changes
Adds one log line on the success path.
logToFilecall the way the sink does, so the no-leak assertion covers a token passed anywhere in a call rather than only in the first argument.Test plan
npx vitest run src/lib/__tests__/gateway-session.test.tsThe no-leak assertion is pinned by mutation: appending the mint response as a second argument, or hiding the token behind a getter or a
toJSON, each turn it red.logToFileis variadic and renders every argument throughJSON.stringify, so a guard reading only the first argument passes all three while the token reaches disk.Known gap: nothing redacts at the sink, and
redactSecretsmatchesph[xspc]_but not thephe_prefix this module mints. That predates this change and is worth a follow-up, since the log is a file users are asked to attach to bug reports.LLM context
Authored by Claude Code (Opus 5). Requires human review.