my spaghetti code contains less pasta than yours

[miodvallat]

Short description

Continuing the recent work on acknowledging the world has moved and the systems PowerDNS software runs on are all providing the OpenSSL 1.1 API or a close equivalent, we can drop configure-time checks for various libssl functions which have been introduced in OpenSSL 1.1.0 or before. There were even a few of them, which are being checked for, but are not used anymore in the code.

Checklist

I have:

• read the CONTRIBUTING.md document
• read and accepted the Developer Certificate of Origin document, including the AI Policy, and added a "Signed-off-by" to my commits
• compiled this code
• tested this code
• included documentation (including possible behaviour changes)
• documented the code
• added or modified regression test(s)
• added or modified unit test(s)

[pieterlexis]

love it, but it might need some explicit words in the upgrade guides that OpenSSL < 1.1 is no longer supported.

[coveralls]

Coverage Report for CI Build 33637544035

Coverage increased (+0.005%) to 71.207%

Details

• Coverage increased (+0.005%) from the base build.
• Patch coverage: 1 uncovered change across 1 file (0 of 1 lines covered, 0.0%).
• 53 coverage regressions across 14 files.

Uncovered Changes

File	Changed	Covered	%
pdns/libssl.cc	1	0	0.0%

Coverage Regressions

53 previously-covered lines in 14 files lost coverage.

Top 10 Files by Coverage Loss	Lines Losing Coverage	Coverage
pdns/recursordist/syncres.cc	9	81.53%
pdns/recursordist/lwres.cc	8	66.78%
pdns/misc.cc	7	60.22%
pdns/auth-secondarycommunicator.cc	4	57.99%
pdns/dnsdistdist/dnsdist-carbon.cc	4	59.71%
pdns/iputils.hh	4	74.59%
pdns/libssl.cc	4	60.15%
pdns/recursordist/aggressive_nsec.cc	3	66.17%
pdns/recursordist/test-syncres_cc2.cc	3	79.39%
pdns/recursordist/pdns_recursor.cc	2	75.57%

---

Coverage Stats

Relevant Lines:	173667
Covered Lines:	135564
Line Coverage:	78.06%
Relevant Branches:	83000
Covered Branches:	47201
Branch Coverage:	56.87%
Branches in Coverage %:	Yes
Coverage Strength:	7688713.63 hits per line

---

💛 - Coveralls

[Habbie]

love it, but it might need some explicit words in the upgrade guides that OpenSSL < 1.1 is no longer supported.

I opted against this in the previous PR that actually dropped < 1.1 support, because no distro of interest ships 1.0 any more, but we can have a note, sure.