Repository navigation
Commit 7329393
Skip getModule E2E tests on in-box Windows PowerShell
CanSendGetModuleRequestAsync and CanSendGetModuleRequestForMissingModuleAsync
were the only tests in LanguageServerProtocolMessageTests still using
[SkippableFact]/[Fact] instead of [SkippableFactOnWindowsPowerShell]. After the
rebase onto main's E2E harness changes (#2323), LSPTestsFixture no longer starts
the server under in-box Windows PowerShell, so PsesLanguageClient is null on that
leg. Every other test in the class skips at discovery time there; these two ran
anyway and threw NullReferenceException. Decorate them with the same attribute so
they skip at discovery alongside their siblings. The attribute keeps the
SkippableFact discoverer, so the Constrained Language Mode Skip.If in
CanSendGetModuleRequestAsync still works, and both tests continue to run on
Linux, macOS, and the PowerShell 7 Windows legs.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>1 parent 3ab4c88 commit 7329393
1 file changed
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1306 | 1306 | | |
1307 | 1307 | | |
1308 | 1308 | | |
1309 | | - | |
| 1309 | + | |
1310 | 1310 | | |
1311 | 1311 | | |
1312 | 1312 | | |
| |||
1344 | 1344 | | |
1345 | 1345 | | |
1346 | 1346 | | |
1347 | | - | |
| 1347 | + | |
1348 | 1348 | | |
1349 | 1349 | | |
1350 | 1350 | | |
| |||
0 commit comments