Skip to content

fix flows multi select readability by using checkbox - #23034

Open
uinstinct wants to merge 1 commit into
PrefectHQ:mainfrom
uinstinct:flows-multiselect
Open

fix flows multi select readability by using checkbox#23034
uinstinct wants to merge 1 commit into
PrefectHQ:mainfrom
uinstinct:flows-multiselect

Conversation

@uinstinct

Copy link
Copy Markdown
Contributor

The ticks on the extreme right are unreadable and problematic to match with their labels on the left.

before

image

after

image

Checklist

  • This pull request references any related issue by including "closes <link to issue>"
    • If no issue exists and your change is not a small fix, please create an issue first.
  • If this is a complex change, a maintainer has confirmed the proposed approach on the linked issue.
  • If this pull request adds or changes functionality, it includes tests or explains why tests are not needed.
  • If this pull request changes user-facing behavior, it updates documentation or explains why documentation is not needed.
  • If this pull request removes docs files, it includes redirect settings in mint.json.
  • If this pull request adds functions or classes, it includes helpful docstrings.

@github-actions github-actions Bot added the ui Related to the Prefect web interface label Sep 4, 2026

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 potential issue.

Devin Review

<FlowMultiSelect
selectedFlowIds={selectedFlowIds}
onToggleFlow={handleToggleFlow}
onSelectFlowIds={setSelectedFlowIds}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Selection behavior lacks regression coverage

Tests only verify labels and opening the list. Add coverage for selection, deselection, clearing, and checkbox state under the testing standard.

Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@uinstinct Can you add a test or two to satisfy this review comment?

@uinstinct uinstinct changed the title fix flows multi select readable by using checkbox fix flows multi select readability by using checkbox Sep 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ui Related to the Prefect web interface

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants