Skip to content

Running --tags reinstall-htr2hpc wipes escriptorium_setup patches #429

Description

@tanhaow

Problem

When running `ansible-playbook ... --tags reinstall-htr2hpc`, the `build_project_repo` role runs (due to its `tags: [always]` + `force: true` git checkout) and overwrites the patches applied by `escriptorium_setup`. The `Customize eScriptorium` block in `escriptorium_setup` is only tagged `escriptorium`, so it does not re-run, leaving the patches missing.

Affected tasks

  • Rename default segtrain/train tasks to `es_segtrain`/`es_train`
  • Import htr2hpc replacement training tasks
  • Other eScriptorium customizations in the `Customize eScriptorium` block

Possible fix

Add `reinstall-htr2hpc` tag to the `Customize eScriptorium` block so patches are re-applied whenever `--tags reinstall-htr2hpc` is used. Alternatively, consider removing the `reinstall-htr2hpc` tag entirely now that `--upgrade` ensures htr2hpc is reinstalled on every full deploy (PR #428).

Current mitigation

PR #428 added `--upgrade` to the htr2hpc pip install, so a full deploy now reinstalls htr2hpc automatically without needing `--tags reinstall-htr2hpc`. The problematic scenario is therefore rare but still possible.

🤖 Supported-by: claude-sonnet-4.6

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions