Repository navigation
Commit c430c90
Fix Windows CI: assert path shapes with either separator
The one failing test, "the host location is named per platform", asked
hostDataDir for the macOS answer and then demanded forward slashes of it.
But path.join always joins with the separator of the machine it is running
on — the platform argument chooses the folder NAMES, nothing more — so on
the Windows runner the answer reads \Users\x\Library\Application
Support\TreeMap: right names, host separators, failed pattern.
Pre-existing, not from this branch: the Tests runs on 931aeb0 and 5f99e8b
were already red on Windows with this same single test (confirmed via the
public check-run annotations). The previous session guarded two D3 tests
for Windows but this third one only surfaced in a run that finished after
its final push. macOS and Linux stayed green throughout.
The pattern now accepts either separator; behaviour is untouched.
Suite 828 (826 pass, 2 platform skips) locally.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>1 parent 38d7ef0 commit c430c90
2 files changed
Lines changed: 11 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
300 | 300 | | |
301 | 301 | | |
302 | 302 | | |
303 | | - | |
| 303 | + | |
| 304 | + | |
| 305 | + | |
| 306 | + | |
| 307 | + | |
304 | 308 | | |
305 | 309 | | |
306 | 310 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
232 | 232 | | |
233 | 233 | | |
234 | 234 | | |
235 | | - | |
| 235 | + | |
| 236 | + | |
| 237 | + | |
| 238 | + | |
| 239 | + | |
| 240 | + | |
236 | 241 | | |
237 | 242 | | |
238 | 243 | | |
| |||
0 commit comments