Repository navigation
fix: implement pending room invitations instead of direct member addition - #3240
codecrafted1 wants to merge 5 commits into
Conversation
GSSoC Label Checklist 🏷️@Priyanshu-byte-coder — please apply the appropriate labels before merging: Difficulty (pick one):
Quality (optional):
Validation (required to score):
|
|
please review this pr |
|
Heads up: this overlaps #3269, which implements the same pending-room-invitations feature (invitations API, PendingInvitations UI, and a I'll review both and pick one — if you think yours covers something #3269 doesn't, say so here and I'll weigh that. Note CI is currently red on this branch (Type check + Build fail), so it needs fixing either way. |
|
Closing in favor of #3269, which has now been merged. Both PRs implemented pending room invitations; #3269 is the more complete version — it ships the migration and schema update, the types, both API routes, and the UI ( This branch covers 4 files with no UI layer, and CI is currently red here (Type check, Build and Playwright all fail). Thanks for tackling the same bug — the invite-without-consent issue is fixed on |
📝 Description
This PR updates the room invitation flow to prevent users from being added to collaboration rooms immediately after entering their GitHub username.
Changes
createRoomInvitation()helper to create pending room invitations.getPendingInvitation()helper to check for existing pending invitations.room_members.Why?
Previously, inviting a user immediately inserted them into the
room_memberstable, making them a full room member without any confirmation or approval.This change introduces the first step toward a consent-based invitation flow by storing invitations separately instead of granting immediate room access.
🔗 Related Issue
Closes #3239
🏷️ Type of Change
📋 Checklist
Notes
This PR introduces pending room invitations as the backend foundation. Users are no longer added directly to a room when invited.