Commit 2da2aed
committed
BUG: Route runtests.sh ruff invocations through PY_EXE
runtests.sh calls every other formatter (black, isort, pylint, pytype)
via "${PY_EXE}" -m so it targets the same interpreter the
is_pip_installed() guard checked. The ruff invocations still called a
bare `ruff` off PATH, so is_pip_installed("ruff") could pass against
$PY_EXE while the invocation ran a different (or absent) ruff from
PATH. In a clean venv built per CONTRIBUTING.md with no editable
PATH entry, ./runtests.sh --codeformat fails with
"ruff: command not found" even though ruff is installed and
importable from $PY_EXE.
Reproduced: with $PY_EXE pointed at a venv holding ruff and that
venv absent from PATH, the old `ruff --version` failed with
"command not found"; "${PY_EXE}" -m ruff --version succeeded.
Signed-off-by: Hans Johnson <hans-johnson@uiowa.edu>1 parent 9ea04d4 commit 2da2aed
1 file changed
Lines changed: 3 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
595 | 595 | | |
596 | 596 | | |
597 | 597 | | |
598 | | - | |
| 598 | + | |
599 | 599 | | |
600 | 600 | | |
601 | 601 | | |
602 | | - | |
| 602 | + | |
603 | 603 | | |
604 | | - | |
| 604 | + | |
605 | 605 | | |
606 | 606 | | |
607 | 607 | | |
| |||
0 commit comments