Commit d43bf62
fix: emit nnUNet store_true flags as bare CLI args in nnUNetV2Runner (#8968)
Fixes #8237 .
### Description
The runner passed boolean flags like `--c` through as `--c True`, but
nnU-Net treats these as `store_true` flags that take no value, so it
errored out with `unrecognized arguments: True`. Now we emit just the
bare flag when it's set, drop it when it isn't, and leave the other args
alone.
### Types of changes
- [x] Non-breaking change (fix or new feature that would not break
existing functionality).
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit
* **Bug Fixes**
* Improved how command-line options are passed for training and
validation, so boolean settings now behave as expected.
* Validation now runs through the standard training workflow with
validation enabled, helping ensure more consistent results.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
---------
Signed-off-by: Soumya Snigdha Kundu <soumya_snigdha.kundu@kcl.ac.uk>
Signed-off-by: Eric Kerfoot <17726042+ericspod@users.noreply.github.com>
Co-authored-by: Eric Kerfoot <17726042+ericspod@users.noreply.github.com>1 parent 946fd4f commit d43bf62
1 file changed
Lines changed: 4 additions & 7 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
596 | 596 | | |
597 | 597 | | |
598 | 598 | | |
599 | | - | |
600 | 599 | | |
601 | | - | |
| 600 | + | |
| 601 | + | |
602 | 602 | | |
603 | | - | |
604 | | - | |
605 | | - | |
606 | | - | |
| 603 | + | |
607 | 604 | | |
608 | | - | |
| 605 | + | |
609 | 606 | | |
610 | 607 | | |
611 | 608 | | |
| |||
0 commit comments