Skip to content

Commit 115d575

Browse files
committed
Simplify expression.
1 parent 9f416cb commit 115d575

2 files changed

Lines changed: 9 additions & 5 deletions

File tree

‎packages/ts-components/src/standard/tabs/tabs.test.ts‎

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ import { defineTabsComponents } from './tabs'
99

1010
describe('Tabs rendering', () => {
1111
it.each([
12-
[undefined, 'false'],
12+
[undefined, null],
1313
[true, 'true'],
1414
[false, 'false'],
1515
])(
@@ -31,7 +31,11 @@ describe('Tabs rendering', () => {
3131
}),
3232
},
3333
)
34-
expect(html).toContain(`data-mobile-select="${expected}"`)
34+
if (expected === null) {
35+
expect(html).not.toContain('data-mobile-select=')
36+
} else {
37+
expect(html).toContain(`data-mobile-select="${expected}"`)
38+
}
3539
} finally {
3640
cleanup()
3741
}
@@ -66,13 +70,13 @@ describe('Tabs rendering', () => {
6670
const root = document.querySelector('#configurable-tabs')
6771
const other = document.querySelector('#default-tabs')
6872
expect(root?.getAttribute('data-mobile-select')).toBe('false')
69-
expect(other?.getAttribute('data-mobile-select')).toBe('false')
73+
expect(other?.getAttribute('data-mobile-select')).toBeNull()
7074

7175
mobileSelect(true)
7276
expect(root?.getAttribute('data-mobile-select')).toBe('true')
7377
mobileSelect(false)
7478
expect(root?.getAttribute('data-mobile-select')).toBe('false')
75-
expect(other?.getAttribute('data-mobile-select')).toBe('false')
79+
expect(other?.getAttribute('data-mobile-select')).toBeNull()
7680
expect(selectedTab()).toBe('details')
7781
expect(
7882
document.querySelector<HTMLInputElement>('#details')?.checked,

‎packages/ts-components/src/standard/tabs/tabs.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ export interface TabPane {
4949
tabClasses?: ComputedRef<string>
5050
}
5151

52-
const tabsTemplate = html`<section class="tabs" :class="classes" :data-mobile-select="mobileSelect === true ? 'true' : 'false'">
52+
const tabsTemplate = html`<section class="tabs" :class="classes" :data-mobile-select="mobileSelect">
5353
<slot name="header"></slot>
5454
<div class="tabs__list" role="tablist" :aria-label="ariaLabel || 'Tabs'">
5555
<slot></slot>

0 commit comments

Comments
 (0)