Skip to content

Commit 2a3b537

Browse files
committed
[docs] clarify command IDs for host transfer tools
Signed-off-by: Viwat Vchirawongkwin <viwat.v@chula.ac.th>
1 parent 6ff052b commit 2a3b537

2 files changed

Lines changed: 18 additions & 0 deletions

File tree

‎docs/specifications/protocol.md‎

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -113,6 +113,16 @@ that ordering.
113113
- `LEN` — payload length, little-endian `uint16` (≤ 65535).
114114
- `CRC32` — IEEE CRC-32 over `VER…PAYLOAD` (the header + payload, excluding the CRC itself), little-endian.
115115

116+
**Host qualification-tool clarification (2026-09-06).** The nonzero `CMD`
117+
request-ID rule also applies to no-response commands such as `FILE_PUT_DATA`.
118+
Absence of a `RSP` does not make its ID irrelevant. Valid transfer benches
119+
MUST allocate every data submission, including a Go-Back-N resend, from the
120+
same 1–255 wrapping allocator as their transfer-control commands. They MUST
121+
NOT let an unbounded counter truncate to zero at wire encoding. This changes
122+
no wire field, response behavior, chunk, window, ACK watermark, retransmit
123+
policy, or measurement boundary. Raw malformed-ID construction remains
124+
available solely for explicit negative protocol tests, not valid transfers.
125+
116126
For a response-bearing command, the connection-local correlation key is the
117127
originating `{OPCODE, ID}` pair and the matching frame's `TYPE` is `RSP`. A
118128
pending command MUST complete only from a frame with all three exact values.

‎tests/firmware_tests/hil/README.md‎

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,14 @@ firmware-test-author**; none of this ships in the firmware image.
88
A milestone gate is green **only on a real-hardware HIL demo**, not on merged
99
code (PRD §1B.7). These drivers are that demo, made repeatable.
1010

11+
Every valid outbound `CMD`, including no-response `FILE_PUT_DATA`, uses a
12+
request ID in 1–255. Transfer data and controls share a wrapping allocator;
13+
each Go-Back-N resend obtains another valid ID without waiting for a data
14+
`RSP`. ID zero is reserved for `EVT` and intentional malformed-input tests.
15+
Host regression coverage must exercise more than 255 submissions and feed
16+
captured frames through the unchanged native wire-admission decision. These
17+
tool checks do not replace actual candidate/board HIL evidence.
18+
1119
## Files
1220

1321
| File | Role |

0 commit comments

Comments
 (0)