[red] Reject stale connected board identity

Signed-off-by: Viwat Vchirawongkwin <viwat.v@chula.ac.th>

Author: yyods

app/test/support/shell_harness.dart

@@ -113,7 +113,7 @@ FakeConnection fakeConnection({
 /// radio, NO BleLink. The chrome (pill/toolbar/nav) keeps reading the scripted
 /// [connection] via the [connectionProvider] override, so every existing shell
 /// assertion holds unchanged.
-Future<void> pumpShell(
+Future<PbleConnectionManager> pumpShell(
   WidgetTester tester, {
   required FakeConnection connection,
   ShellSurface surface = ipadLandscape,
@@ -153,4 +153,5 @@ Future<void> pumpShell(
     ),
   );
   await tester.pumpAndSettle();
+  return manager;
 }

app/test/unit/connect_controller_test.dart

@@ -0,0 +1,91 @@
+// SPDX-License-Identifier: MIT
+// Part of PyBLE (https://pyble.dev) — see /LICENSE.
+
+import 'dart:async';
+
+import 'package:flutter_test/flutter_test.dart';
+
+import 'package:pyble/connect/connect.dart';
+import 'package:pyble/pble/pble.dart';
+
+import '../support/fake_readiness_seam.dart';
+
+class _DelayedInfoConnection extends FakeConnection {
+  _DelayedInfoConnection() : super(initial: ConnState.ready);
+
+  final Completer<DeviceInfo> _info = Completer<DeviceInfo>();
+  int deviceInfoCalls = 0;
+
+  @override
+  Future<DeviceInfo> deviceInfo() {
+    deviceInfoCalls += 1;
+    return _info.future;
+  }
+
+  void completeInfo(DeviceInfo info) => _info.complete(info);
+}
+
+DeviceInfo _info(String deviceId, String agentVersion) => DeviceInfo(
+  chip: 'esp32-s3',
+  mpyVersion: '1.28.0',
+  freeMem: 48000,
+  fsRoot: '/',
+  deviceId: deviceId,
+  agentVersion: agentVersion,
+);
+
+void main() {
+  test(
+    'late DeviceInfo from a detached board cannot replace current identity',
+    () async {
+      final _DelayedInfoConnection first = _DelayedInfoConnection();
+      final _DelayedInfoConnection second = _DelayedInfoConnection();
+      final FakeSeamReadiness readiness = FakeSeamReadiness();
+      final Map<String, _DelayedInfoConnection> boards =
+          <String, _DelayedInfoConnection>{'board-a': first, 'board-b': second};
+      final PbleConnectionManager manager = PbleConnectionManager(
+        scanner: FakeScanner(),
+        readiness: readiness,
+        connectionFactory: (String id) async => boards[id]!,
+      );
+      final ConnectController controller = ConnectController(manager);
+      addTearDown(() async {
+        controller.dispose();
+        await manager.dispose();
+        await readiness.dispose();
+      });
+      final List<String> publishedIds = <String>[];
+      controller.addListener(() {
+        final String? id = controller.state.deviceInfo?.deviceId;
+        if (id != null) publishedIds.add(id);
+      });
+
+      await manager.connect('board-a');
+      await pumpEventQueue();
+      expect(first.deviceInfoCalls, 1);
+
+      await manager.disconnect();
+      await manager.connect('board-b');
+      await pumpEventQueue();
+      expect(controller.state.deviceInfo, isNull);
+
+      second.completeInfo(_info('BBBB', '0.7.0'));
+      await pumpEventQueue();
+      first.completeInfo(_info('AAAA', '0.6.0'));
+      await pumpEventQueue();
+
+      expect(
+        second.deviceInfoCalls,
+        1,
+        reason: 'the replacement session must not wait for the old request',
+      );
+      expect(controller.state.deviceInfo?.deviceId, 'BBBB');
+      expect(controller.state.deviceInfo?.agentVersion, '0.7.0');
+      expect(
+        publishedIds,
+        isNot(contains('AAAA')),
+        reason: 'prior-session identity must never flash in the live UI',
+      );
+    },
+  );
+}

app/test/widget/app_shell_test.dart

@@ -22,6 +22,7 @@
 // HAND-OFF provenance: lib/app → app-architect; lib/pble → app-protocol-engineer.
 
 import 'package:flutter/material.dart';
+import 'package:flutter/rendering.dart';
 import 'package:flutter_test/flutter_test.dart';
 
 import 'package:pyble/app/app.dart';
@@ -231,6 +232,7 @@ void main() {
         );
 
         final AppLocalizations l10n = _l10n(tester);
+        expect(_pillLabel('Ready'), findsOneWidget);
         expect(
           find.descendant(
             of: find.byKey(_pillKey),
@@ -283,6 +285,108 @@ void main() {
         expect(find.byTooltip('Disconnect'), findsOneWidget);
       },
     );
+
+    testWidgets(
+      'Connect-to-IDE transition retains identity in ready and running',
+      (tester) async {
+        final FakeConnection connection = fakeConnection(
+          initial: ConnState.connecting,
+          info: fakeDeviceInfo(deviceId: '5646', agentVersion: '0.6.0'),
+        );
+        final PbleConnectionManager manager = await pumpShell(
+          tester,
+          connection: connection,
+          surface: ipadLandscape,
+        );
+
+        final AppLocalizations l10n = _l10n(tester);
+        expect(
+          find.text(l10n.connectEmptyTitle),
+          findsOneWidget,
+          reason: 'the pre-connection Connect surface starts mounted',
+        );
+
+        await manager.connect('shell-transition-board');
+        connection.emit(ConnState.ready);
+        await tester.pumpAndSettle();
+
+        expect(find.text(l10n.connectEmptyTitle), findsNothing);
+        expect(find.text(l10n.connectDeviceInfoTitle), findsNothing);
+        expect(_pillLabel('Ready'), findsOneWidget);
+        expect(
+          find.text(l10n.connStatusBoardInfoSummary('5646', '0.6.0')),
+          findsOneWidget,
+        );
+        expect(
+          find.bySemanticsLabel(
+            l10n.connStatusBoardInfoSemanticLabel('Ready', '5646', '0.6.0'),
+          ),
+          findsOneWidget,
+        );
+
+        connection.emit(ConnState.running);
+        await tester.pumpAndSettle();
+
+        expect(_pillLabel('Running'), findsOneWidget);
+        expect(
+          find.text(l10n.connStatusBoardInfoSummary('5646', '0.6.0')),
+          findsOneWidget,
+        );
+        expect(
+          find.bySemanticsLabel(
+            l10n.connStatusBoardInfoSemanticLabel('Running', '5646', '0.6.0'),
+          ),
+          findsOneWidget,
+        );
+      },
+    );
+
+    testWidgets('tight 2x layout ellipsizes identity but not state', (
+      tester,
+    ) async {
+      tester.platformDispatcher.textScaleFactorTestValue = 2;
+      addTearDown(tester.platformDispatcher.clearTextScaleFactorTestValue);
+      const String longId = 'BOARD-IDENTITY-1234567890';
+      const String longVersion = '0.6.0-development-metadata';
+
+      await pumpShell(
+        tester,
+        connection: fakeConnection(
+          initial: ConnState.ready,
+          info: fakeDeviceInfo(deviceId: longId, agentVersion: longVersion),
+        ),
+        surface: phonePortrait,
+      );
+
+      final AppLocalizations l10n = _l10n(tester);
+      final Finder stateFinder = _pillLabel('Ready');
+      final Finder summaryFinder = find.descendant(
+        of: find.byKey(_pillKey),
+        matching: find.text(
+          l10n.connStatusBoardInfoSummary(longId, longVersion),
+        ),
+      );
+      expect(stateFinder, findsOneWidget);
+      expect(summaryFinder, findsOneWidget);
+      expect(
+        tester.renderObject<RenderParagraph>(stateFinder).didExceedMaxLines,
+        isFalse,
+        reason: 'the full state word is the non-negotiable minimum signal',
+      );
+      expect(
+        tester.renderObject<RenderParagraph>(summaryFinder).didExceedMaxLines,
+        isTrue,
+        reason: 'only the appended identity may ellipsize under pressure',
+      );
+      expect(
+        find.bySemanticsLabel(
+          l10n.connStatusBoardInfoSemanticLabel('Ready', longId, longVersion),
+        ),
+        findsOneWidget,
+        reason: 'visual ellipsis must not truncate accessibility metadata',
+      );
+      expect(tester.takeException(), isNull);
+    });
   });
 
   group('FR-UI-1 collapsible landscape Files sidebar', () {