Skip to content

Commit 9c1a2bc

Browse files
committed
[docs] freeze responsive files action toolbar
Signed-off-by: Viwat Vchirawongkwin <viwat.v@chula.ac.th>
1 parent ede5bd8 commit 9c1a2bc

4 files changed

Lines changed: 9 additions & 6 deletions

File tree

‎docs/decisions/0043-session-bound-visible-file-multi-delete.md‎

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -31,10 +31,12 @@ from PyBLE's Material design system and PBLE/1 contract.
3131
empty folder can be removed. Recursive deletion is not introduced or
3232
implied.
3333

34-
2. **Selection is explicit, local, and temporary.** A labelled Select action is
35-
the discoverable entry point; long-pressing an eligible file is an optional
36-
shortcut that enters selection and selects that row. In selection mode, a
37-
tap or keyboard activation toggles a checkbox instead of opening the file.
34+
2. **Selection is explicit, local, and temporary.** A localized
35+
tooltip/semantics-labelled Select icon remains directly visible in both the
36+
compact one-row and roomy normal Files toolbar; long-pressing an eligible
37+
file is an optional shortcut that enters selection and selects that row. In
38+
selection mode, a tap or keyboard activation toggles a checkbox instead of
39+
opening the file.
3840
The normal navigation, create, transfer, import, rename, delete, and
3941
Open-as-Blocks affordances are replaced by a contextual selected-count bar.
4042
Cancel, Escape, system Back, navigation that hides the Files presentation, a

‎docs/specifications/App/TDD.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1891,7 +1891,7 @@ class FileExplorerState {
18911891

18921892
Every verb wraps the typed `PbleException` ([§14.1](#141-status-byte--typed-exception--localized-message)) into a `FileErrorKind` the widget renders as an actionable, localized message (FR-FILES-3). Transfers report `progress` continuously and succeed only on the seam's whole-file CRC/size verification (FR-FILES-4, already enforced in `lib/pble`). File ops are enabled only while the session is up (`ConnState.ready`/`running`); disconnected shows the existing `folder_off` guidance with no destructive action. **Deferred:** a true export-to-device-storage **Download** (needs local persistence + a `path_provider`-class dep, out of scope) — **open-in-editor is the read-into-app path** for this increment. `.py`/data-only holds (CON-3): the workspace never produces `.mpy`/`.pyc`.
18931893

1894-
**Visible regular-file multi-delete — FROZEN (`[docs]` 2026-08-27, [ADR-0043](../../decisions/0043-session-bound-visible-file-multi-delete.md)).** `FilesView` owns a temporary selection of eligible shown direct regular-file names plus captured `cwd` and opaque session stamp. A labelled Select action or eligible-row long press enters; rows become checked toggles, Select all includes eligible shown files only, and Cancel/Escape/Back exits. Folders and locked entries never enter the set. The contextual bar replaces normal Files actions and uses a live selected count, destructive Delete, and item progress. One scrollable dialog presents the exact `cwd` and ordered names with Cancel focused before Delete.
1894+
**Visible regular-file multi-delete — FROZEN (`[docs]` 2026-08-27, [ADR-0043](../../decisions/0043-session-bound-visible-file-multi-delete.md)).** `FilesView` owns a temporary selection of eligible shown direct regular-file names plus captured `cwd` and opaque session stamp. A localized tooltip/semantics-labelled Select icon remains directly visible in both compact and roomy normal toolbars; it or an eligible-row long press enters selection. The compact normal toolbar keeps GitHub import direct and moves Refresh, New file, New folder, and Upload into one labelled overflow so normal action icons remain exactly one row. Rows become checked toggles, Select all includes eligible shown files only, and Cancel/Escape/Back exits. Folders and locked entries never enter the set. The contextual bar replaces normal Files actions and uses a live selected count, destructive Delete, and item progress. One scrollable dialog presents the exact `cwd` and ordered names with Cancel focused before Delete.
18951895

18961896
`deleteMany` snapshots the controller's displayed order, rejects duplicate/unknown/directory/unsafe/reserved/overlength names and a mismatched expected `cwd` or session before the first `Connection.delete`, then awaits each delete serially. A second valid batch receives a local `busy` failure, reports all of its ordered paths unattempted, and sends no verb. On the first typed error or session change it starts no later delete and returns exact succeeded/current/unattempted accounting. It performs no rollback or automatic retry. If at least one delete was issued, it calls `listDir(capturedCwd)` exactly once only while the captured session is current; a primary delete error wins over a reconciliation error. Complete success clears selection; failed/partial removes succeeded names, keeps still-rendered unresolved names selected, focuses and announces one localized result, and leaves the refreshed listing visible. Reconciliation cannot create a selected ghost for an absent failed path, and a later selection edit dismisses rather than mutates prior result accounting. Navigation that hides Files clears local selection even if an already-issued, non-cancellable board delete must finish; switching Editor/Console centre focus while the landscape Files sidebar remains visible does not hide it. Folders retain the existing single empty-directory delete; there is no recursion or new PBLE opcode.
18971897

‎docs/specifications/App/design-system.md‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -393,6 +393,7 @@ hosts are visually distinct:
393393
Frozen patterns; copy authored in the Files feature story.
394394

395395
- **Path / breadcrumb header:** current segment as `labelLarge` with an up/back affordance in the §7.4 trailing slot; `fs_root` and path segments render verbatim via `SignalType.code` (FR-I18N-4), never localized.
396+
- **Normal action toolbar:** ordinary Files actions occupy exactly one horizontal action row below the path; they MUST NOT wrap into a second icon row, scroll horizontally, clip, or shrink below the 48 dp target. The localized, tooltip-labelled Select-files and GitHub-import actions remain directly visible in a constrained landscape pane. Refresh, New file, New folder, and Upload move together into one localized, keyboard- and screen-reader-reachable labelled overflow when all six direct actions do not fit. A roomy Files surface exposes all six actions directly and omits the overflow. Overflow items retain the same enabled state and invoke the same action as their direct counterparts.
396397
- **Multi-select contextual bar:** on multi-select, the §7.4 pane header is replaced by a bar showing the selected count (`titleMedium`) + Cancel, Select-all-shown, and bulk Delete actions; destructive bulk delete uses `colorScheme.error` (§7.8); selected rows use the §7.10 `surfaceContainerHigh` selection fill. The current `cwd` remains visible as one ellipsized `SignalType.code` line. In a narrow Files pane or at 2× text the bar grows to two rows; it never shrinks a target below 48 dp or clips the count/actions.
397398
- **Selection eligibility:** the first FR-FILES-5 increment selects regular files only. Folders remain visible but do not gain a checkbox; locked §7.10 control-plane/scratch rows are excluded. “Select all shown” means every eligible file present in the current rendered listing, never descendants or entries omitted by `FILE_LIST more == 1`.
398399
- **Bulk confirmation and result:** one scrollable destructive confirmation shows the exact folder and every ordered filename, with Cancel focused before Delete. During sequential deletion the contextual bar stays locked and shows item progress. A complete result exits selection; a failed/partial live-region result keeps only unresolved names selected and states how many were deleted and remain. Neither copy nor color may imply atomic rollback.

‎docs/specifications/App/specs.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -153,7 +153,7 @@ The client implements the PBLE/1 wire contract; it references [protocol.md](../p
153153

154154
**Working-loop increment — FROZEN (A-30 subset · `[docs]` 2026-07-02, [ADR-0010](../../decisions/0010-working-loop-in-memory-document.md), [TDD §11.6](TDD.md#116-working-loop-provider-contract-frozen)).** In scope: `listDir` rooted at `fs_root` with into/up navigation, open-in-editor (`getFile` → editor buffer), upload-current-buffer (`putFile`), mkdir, delete, rename, `newFile`, continuous transfer progress + whole-file CRC success, typed-error → localized message, disabled-with-guidance while disconnected (FR-FILES-1/2/3/4/8, binding via the `Connection` seam only, CON-8). **Deferred:** export-to-device-storage **Download** (needs local persistence + a new dep — open-in-editor is the read-into-app path this increment). `.py`/data-only holds (FR-FILES-7, CON-3).
155155

156-
**Visible-file multi-delete — FROZEN (`[docs]` 2026-08-27, [ADR-0043](../../decisions/0043-session-bound-visible-file-multi-delete.md), [TDD §11.6](TDD.md#116-working-loop-provider-contract-frozen)).** A labelled Select action and eligible-file long press enter a contextual mode scoped to the exact shown direct regular files in one `cwd`; folders, descendants, firmware-reserved/control-plane paths, transfer scratch paths, and omitted/truncated entries are never selected. Select all means all eligible **shown files**. Tap/Space toggles instead of opening; normal navigation and mutation affordances are unavailable until Cancel/Escape/Back. One confirmation displays the exact folder and ordered filenames. The app then validates the captured `cwd`, paths, and opaque connection-session stamp, awaits ordinary `Connection.delete` calls sequentially, stops before the next path on the first failure/session change, never rolls back or retries, and refreshes the captured folder once only if the same session remains current. Complete, failed, and partial results truthfully identify succeeded, failed/current, and unattempted paths; still-rendered unresolved files remain selected, while reconciliation never creates a selected ghost for an absent path. Navigation that hides Files clears selection without cancelling an already-issued board mutation. Folders retain the existing one-at-a-time empty-directory delete and no recursive delete exists.
156+
**Visible-file multi-delete — FROZEN (`[docs]` 2026-08-27, [ADR-0043](../../decisions/0043-session-bound-visible-file-multi-delete.md), [TDD §11.6](TDD.md#116-working-loop-provider-contract-frozen)).** A localized tooltip/semantics-labelled Select action remains directly visible when the normal Files toolbar compacts into one action row; Refresh, New file, New folder, and Upload move into one labelled overflow while GitHub import also remains direct. The Select action and eligible-file long press enter a contextual mode scoped to the exact shown direct regular files in one `cwd`; folders, descendants, firmware-reserved/control-plane paths, transfer scratch paths, and omitted/truncated entries are never selected. Select all means all eligible **shown files**. Tap/Space toggles instead of opening; normal navigation and mutation affordances are unavailable until Cancel/Escape/Back. One confirmation displays the exact folder and ordered filenames. The app then validates the captured `cwd`, paths, and opaque connection-session stamp, awaits ordinary `Connection.delete` calls sequentially, stops before the next path on the first failure/session change, never rolls back or retries, and refreshes the captured folder once only if the same session remains current. Complete, failed, and partial results truthfully identify succeeded, failed/current, and unattempted paths; still-rendered unresolved files remain selected, while reconciliation never creates a selected ghost for an absent path. Navigation that hides Files clears selection without cancelling an already-issued board mutation. Folders retain the existing one-at-a-time empty-directory delete and no recursive delete exists.
157157

158158
### 4.6 Code Editor (`lib/editor/`) — FR-EDIT
159159

0 commit comments

Comments
 (0)