Skip to content

Commit a223003

Browse files
committed
[red] reject post-dispose fragments and unobserved pending errors
Signed-off-by: Viwat Vchirawongkwin <viwat.v@chula.ac.th>
1 parent 7252ca1 commit a223003

1 file changed

Lines changed: 90 additions & 0 deletions

File tree

‎app/test/unit/engine_cleanup_failure_test.dart‎

Lines changed: 90 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ import 'dart:typed_data';
77
import 'package:flutter_test/flutter_test.dart';
88
import 'package:pyble/pble/engine.dart';
99
import 'package:pyble/pble/frame.dart';
10+
import 'package:pyble/pble/fragment.dart';
1011
import 'package:pyble/pble/pble_constants.dart';
1112
import 'package:pyble/pble/pble_exception.dart';
1213

@@ -20,7 +21,96 @@ class _CancelFailureTransport extends FakeByteTransport {
2021
Stream<Uint8List> get inbound => input.stream;
2122
}
2223

24+
class _HeldTransport extends FakeByteTransport {
25+
_HeldTransport() : super(mtu: 23);
26+
final Completer<void> held = Completer<void>();
27+
int submissions = 0;
28+
@override
29+
Future<void> send(Uint8List packet, {required bool acknowledged}) async {
30+
submissions++;
31+
if (submissions == 1) await held.future;
32+
await super.send(packet, acknowledged: acknowledged);
33+
}
34+
}
35+
2336
void main() {
37+
for (final bool fire in <bool>[false, true]) {
38+
test(
39+
'retired ${fire ? 'fire' : 'request'} never submits more held fragments',
40+
() async {
41+
final Completer<void> finished = Completer<void>();
42+
final List<Object> uncaught = <Object>[];
43+
Object? operationError;
44+
int before = 0;
45+
int after = 0;
46+
runZonedGuarded(() async {
47+
final _HeldTransport transport = _HeldTransport();
48+
final PbleEngine engine = PbleEngine(transport);
49+
final PbleFrame command = PbleFrame(
50+
type: Pble.typeCmd,
51+
opcode: (fire ? PbleOpcode.consoleInput : PbleOpcode.run).code,
52+
id: engine.nextId(),
53+
payload: Uint8List(100),
54+
);
55+
final Future<void> observed =
56+
(fire ? engine.fire(command) : engine.request(command))
57+
.then<void>(
58+
(_) {},
59+
onError: (Object error) => operationError = error,
60+
);
61+
await pumpEventQueue();
62+
before = transport.submissions;
63+
await engine.dispose();
64+
await pumpEventQueue();
65+
transport.held.complete();
66+
await observed;
67+
await pumpEventQueue();
68+
after = transport.submissions;
69+
await transport.dispose();
70+
finished.complete();
71+
}, (Object error, StackTrace _) => uncaught.add(error));
72+
await finished.future.timeout(const Duration(seconds: 2));
73+
expect(before, 1);
74+
expect(after, 1);
75+
expect(uncaught, isEmpty);
76+
expect(operationError, isA<PbleTimeoutException>());
77+
},
78+
);
79+
}
80+
81+
test(
82+
'on-time response before retirement still wins over held write completion',
83+
() async {
84+
final _HeldTransport transport = _HeldTransport();
85+
final PbleEngine engine = PbleEngine(transport);
86+
final PbleFrame command = PbleFrame(
87+
type: Pble.typeCmd,
88+
opcode: PbleOpcode.deviceInfo.code,
89+
id: engine.nextId(),
90+
payload: Uint8List(0),
91+
);
92+
final Future<PbleFrame> result = engine.request(command);
93+
await pumpEventQueue();
94+
final PbleFrame response = PbleFrame(
95+
type: Pble.typeRsp,
96+
opcode: command.opcode,
97+
id: command.id,
98+
payload: Uint8List.fromList(<int>[0]),
99+
);
100+
for (final Uint8List packet in PbleFragmenter(
101+
mtu: 23,
102+
).fragment(encodeFrame(response))) {
103+
transport.deliverRawPacket(packet);
104+
}
105+
await pumpEventQueue();
106+
await engine.dispose();
107+
transport.held.complete();
108+
expect((await result).payload, response.payload);
109+
expect(transport.submissions, 1);
110+
await transport.dispose();
111+
},
112+
);
113+
24114
test(
25115
'inbound cancellation failure still fails pending work and closes events',
26116
() async {

0 commit comments

Comments
 (0)