[red] Require identity in connected status pill

Signed-off-by: Viwat Vchirawongkwin <viwat.v@chula.ac.th>

Author: yyods

app/test/support/shell_harness.dart

@@ -77,28 +77,30 @@ const List<String> navDestinations = <String>[
 ];
 
 /// Builds a scriptable [DeviceInfo]. `deviceId`/`label` are DISPLAY-ONLY and
-/// never gate access (SEC-9) — the shell must render with them empty.
+/// never gate access (SEC-9); [agentVersion] is the PyBLE agent firmware SemVer.
 DeviceInfo fakeDeviceInfo({
   String chip = 'esp32-s3',
   String mpyVersion = '1.28.0',
   int freeMem = 48000,
   String fsRoot = '/',
-  String deviceId = '',
+  String deviceId = '5646',
   String label = '',
+  String agentVersion = '0.6.0',
 }) => DeviceInfo(
   chip: chip,
   mpyVersion: mpyVersion,
   freeMem: freeMem,
   fsRoot: fsRoot,
   deviceId: deviceId,
   label: label,
+  agentVersion: agentVersion,
 );
 
 /// A scripted [FakeConnection] in a given initial [ConnState].
 FakeConnection fakeConnection({
   ConnState initial = ConnState.disconnected,
   DeviceInfo? info,
-}) => FakeConnection(initial: initial, deviceInfo: info);
+}) => FakeConnection(initial: initial, deviceInfo: info ?? fakeDeviceInfo());
 
 /// Pumps the real [PybleApp] shell at [surface], with the Connection seam
 /// overridden by a scripted [connection]. Resets the view on teardown.
@@ -127,6 +129,12 @@ Future<void> pumpShell(
     connectionFactory: (String id) async => connection,
   );
   addTearDown(manager.dispose);
+  // A connected shell must exercise the same live manager facade production
+  // uses, so connectControllerProvider can retain/fetch the DeviceInfo proof.
+  if (connection.state.value == ConnState.ready ||
+      connection.state.value == ConnState.running) {
+    await manager.connect('shell-harness-board');
+  }
 
   await tester.pumpWidget(
     ProviderScope(

app/test/widget/app_shell_test.dart

@@ -30,6 +30,7 @@ import 'package:pyble/app/providers.dart';
 import 'package:pyble/console/console.dart';
 import 'package:pyble/editor/editor.dart';
 import 'package:pyble/files/files.dart';
+import 'package:pyble/localization/localization.dart';
 import 'package:pyble/pble/pble.dart';
 
 import '../support/shell_harness.dart';
@@ -55,6 +56,9 @@ const ValueKey<String> _pillKey = ValueKey<String>('connStatusPill');
 Finder _pillLabel(String word) =>
     find.descendant(of: find.byKey(_pillKey), matching: find.text(word));
 
+AppLocalizations _l10n(WidgetTester tester) =>
+    AppLocalizations.of(tester.element(find.byType(Scaffold).first));
+
 /// The run-control toolbar action tooltips (ARB: toolbar{Run,Stop,SoftReboot}).
 /// These always render; their ENABLED state is state-driven from run-control
 /// (A-16, covered by run_toolbar_test.dart). The connection action is separate:
@@ -213,6 +217,73 @@ void main() {
       expect(_pillLabel('Ready'), findsOneWidget);
       expect(_pillLabel('Disconnected'), findsNothing);
     });
+
+    testWidgets(
+      'connected pill retains board ID and firmware after Connect unmounts',
+      (tester) async {
+        await pumpShell(
+          tester,
+          connection: fakeConnection(
+            initial: ConnState.ready,
+            info: fakeDeviceInfo(deviceId: '5646', agentVersion: '0.6.0'),
+          ),
+          surface: ipadLandscape,
+        );
+
+        final AppLocalizations l10n = _l10n(tester);
+        expect(
+          find.descendant(
+            of: find.byKey(_pillKey),
+            matching: find.text(
+              l10n.connStatusWithBoardInfo('Ready', '5646', '0.6.0'),
+            ),
+          ),
+          findsOneWidget,
+        );
+        expect(
+          find.bySemanticsLabel(
+            l10n.connStatusBoardInfoSemanticLabel('Ready', '5646', '0.6.0'),
+          ),
+          findsOneWidget,
+        );
+        expect(
+          find.text(l10n.connectDeviceInfoTitle),
+          findsNothing,
+          reason: 'ADR-0011 replaces the Connect surface once ready',
+        );
+      },
+    );
+
+    testWidgets(
+      'connected pill reports empty additive metadata without gating',
+      (tester) async {
+        await pumpShell(
+          tester,
+          connection: fakeConnection(
+            initial: ConnState.ready,
+            info: fakeDeviceInfo(deviceId: '', agentVersion: ''),
+          ),
+          surface: phonePortrait,
+        );
+
+        final AppLocalizations l10n = _l10n(tester);
+        expect(
+          find.descendant(
+            of: find.byKey(_pillKey),
+            matching: find.text(
+              l10n.connStatusWithBoardInfo(
+                'Ready',
+                l10n.connectDeviceNotReported,
+                l10n.connectDeviceNotReported,
+              ),
+            ),
+          ),
+          findsOneWidget,
+        );
+        expect(tester.takeException(), isNull);
+        expect(find.byTooltip('Disconnect'), findsOneWidget);
+      },
+    );
   });
 
   group('FR-UI-1 collapsible landscape Files sidebar', () {