[green] preserve landscape editing space above the keyboard

Signed-off-by: Viwat Vchirawongkwin <viwat.v@chula.ac.th>

Author: yyods

app/lib/app/shell.dart

@@ -220,6 +220,7 @@ class _LandscapeShell extends ConsumerWidget {
     final bool filesCollapsed = ref.watch(filesPaneCollapsedProvider);
     final bool blocksFocused = selected == AppSurface.blocks;
     final bool blocksConsoleExpanded = ref.watch(blocksConsoleExpandedProvider);
+    final bool keyboardVisible = MediaQuery.viewInsetsOf(context).bottom > 0;
     final AppLocalizations l10n = AppLocalizations.of(context);
 
     final AppSurface centre = _centreSurface(selected);
@@ -331,8 +332,17 @@ class _LandscapeShell extends ConsumerWidget {
             ),
             const Divider(height: 1),
             ConsoleStripView(
-              collapsed: blocksFocused && !blocksConsoleExpanded,
-              onToggle: blocksFocused
+              collapsed:
+                  keyboardVisible || (blocksFocused && !blocksConsoleExpanded),
+              onToggle: keyboardVisible
+                  ? () {
+                      if (blocksFocused) {
+                        ref.read(blocksConsoleExpandedProvider.notifier).state =
+                            true;
+                      }
+                      FocusScope.of(context).unfocus();
+                    }
+                  : blocksFocused
                   ? () {
                       ref.read(blocksConsoleExpandedProvider.notifier).state =
                           !blocksConsoleExpanded;
@@ -410,6 +420,7 @@ class _SurfaceRail extends ConsumerWidget {
     );
     final int selectedIndex = _ideNavSurfaces.indexOf(selected);
     return NavigationRail(
+      scrollable: true,
       selectedIndex: selectedIndex < 0 ? 0 : selectedIndex,
       labelType: NavigationRailLabelType.all,
       onDestinationSelected: (int index) {

app/test/widget/app_shell_test.dart

@@ -115,7 +115,10 @@ void main() {
         await tester.pumpAndSettle();
 
         expect(tester.takeException(), isNull);
-        expect(tester.getSize(editor).height, greaterThanOrEqualTo(80));
+        final Finder viewport = find.byWidgetPredicate(
+          (Widget widget) => widget is EditorSurface,
+        );
+        expect(tester.getSize(viewport).height, greaterThanOrEqualTo(80));
         expect(tester.getRect(editor).bottom, lessThanOrEqualTo(800 - inset));
         expect(
           tester
@@ -131,6 +134,10 @@ void main() {
         await tester.ensureVisible(blocks);
         expect(blocks.hitTestable(), findsOneWidget);
 
+        await tester.tap(find.byTooltip('Expand console'));
+        await tester.pump();
+        expect(tester.widget<EditableText>(editor).focusNode.hasFocus, isFalse);
+
         tester.view.resetViewInsets();
         await tester.pumpAndSettle();
         expect(tester.takeException(), isNull);