synchronize-mip: record step refuses a repository move

The lockfile owns profile to repository. Record this release now fails if
SOURCE_REPOSITORY differs from the locked repository, naming both and telling
the maintainer to edit pydevices-lock.json on the PyDevices branch; otherwise
it updates ref only. The script check remains defence in depth.

Co-authored-by: Brad Barnett <bdbarnett@users.noreply.github.com>

Author: cursoragent

.github/workflows/reusable-synchronize-mip-package.yml

@@ -90,10 +90,15 @@ jobs:
           profile = os.environ["PUBLICATION_PROFILE"]
           if profile not in lock:
               raise SystemExit(f"{profile!r} is not in {path}; add it before publishing")
-          lock[profile] = {
-              "repository": os.environ["SOURCE_REPOSITORY"],
-              "ref": os.environ["SOURCE_REF"],
-          }
+          entry = lock[profile]
+          expected = entry["repository"]
+          got = os.environ["SOURCE_REPOSITORY"]
+          if expected != got:
+              raise SystemExit(
+                  f"profile {profile!r} is locked to {expected}, not {got}; "
+                  f"edit pydevices-lock.json on the PyDevices branch to move the profile"
+              )
+          entry["ref"] = os.environ["SOURCE_REF"]
           path.write_text(json.dumps(lock, indent=2) + "\n")
           print(f"{profile} -> {lock[profile]['ref']}")
           PY

tests/test_synchronize_mip_package.py

@@ -4,15 +4,18 @@
 
 import importlib
 import json
+import os
 import subprocess
 import sys
 import tempfile
+import textwrap
 import unittest
 from pathlib import Path
 
 REPO = Path(__file__).resolve().parents[1]
 SCRIPTS = REPO / "scripts"
 SYNC_SCRIPT = SCRIPTS / "synchronize_mip_package.py"
+SYNC_WORKFLOW = REPO / ".github/workflows/reusable-synchronize-mip-package.yml"
 
 
 def _load_module(name: str):
@@ -118,7 +121,10 @@ def test_audioeffects_dispatch_matches_lockfile(self) -> None:
             self.assertEqual(result.returncode, 0, result.stderr)
             self.assertTrue((mip / "micropython" / "audioeffects" / "manifest.py").is_file())
 
-    def test_stale_audioif_caller_is_rejected_when_lockfile_names_audiocomponents(self) -> None:
+    def test_script_in_isolation_rejects_source_repository_name_that_disagrees_with_lockfile(self) -> None:
+        # Defence in depth only. The publication workflow never presents this
+        # mismatch: Record this release refuses a repository move before the
+        # sync loop runs synchronize_mip_package.py.
         with tempfile.TemporaryDirectory() as tmp:
             root = Path(tmp)
             source = root / "source"
@@ -190,6 +196,82 @@ def test_lockfile_repository_reads_named_entry(self) -> None:
             )
 
 
+def record_release_python() -> str:
+    text = SYNC_WORKFLOW.read_text(encoding="utf-8")
+    start = text.index("- name: Record this release in the lockfile")
+    block = text[start:]
+    begin = block.index("python3 - <<'PY'\n") + len("python3 - <<'PY'\n")
+    end = block.index("\n          PY\n", begin)
+    return textwrap.dedent(block[begin:end])
+
+
+def run_record_step(
+    lockfile: Path,
+    *,
+    profile: str,
+    repository: str,
+    ref: str,
+) -> subprocess.CompletedProcess[str]:
+    with tempfile.TemporaryDirectory() as tmp:
+        script = Path(tmp) / "record_release.py"
+        script.write_text(record_release_python(), encoding="utf-8")
+        env = os.environ.copy()
+        env.update(
+            {
+                "LOCKFILE": str(lockfile),
+                "PUBLICATION_PROFILE": profile,
+                "SOURCE_REPOSITORY": repository,
+                "SOURCE_REF": ref,
+            }
+        )
+        return subprocess.run(
+            [sys.executable, str(script)],
+            capture_output=True,
+            text=True,
+            env=env,
+            check=False,
+        )
+
+
+class RecordLockfileReleaseTests(unittest.TestCase):
+    def test_matching_repository_updates_ref_only(self) -> None:
+        with tempfile.TemporaryDirectory() as tmp:
+            mip = Path(tmp)
+            write_lockfile(mip, {"audioinstruments": "PyDevices/audiocomponents"})
+            lockfile = mip / "pydevices-lock.json"
+            before = json.loads(lockfile.read_text(encoding="utf-8"))
+            result = run_record_step(
+                lockfile,
+                profile="audioinstruments",
+                repository="PyDevices/audiocomponents",
+                ref="v0.3.0",
+            )
+            self.assertEqual(result.returncode, 0, result.stderr)
+            after = json.loads(lockfile.read_text(encoding="utf-8"))
+            self.assertEqual(after["audioinstruments"]["repository"], "PyDevices/audiocomponents")
+            self.assertEqual(after["audioinstruments"]["ref"], "v0.3.0")
+            self.assertEqual(before["audioinstruments"]["repository"], after["audioinstruments"]["repository"])
+
+    def test_mismatched_repository_fails_without_writing(self) -> None:
+        with tempfile.TemporaryDirectory() as tmp:
+            mip = Path(tmp)
+            write_lockfile(mip, {"audioinstruments": "PyDevices/audiocomponents"})
+            lockfile = mip / "pydevices-lock.json"
+            before = lockfile.read_text(encoding="utf-8")
+            result = run_record_step(
+                lockfile,
+                profile="audioinstruments",
+                repository="PyDevices/audioif",
+                ref="v0.3.0",
+            )
+            self.assertNotEqual(result.returncode, 0)
+            self.assertIn("PyDevices/audiocomponents", result.stderr)
+            self.assertIn("PyDevices/audioif", result.stderr)
+            self.assertIn("pydevices-lock.json", result.stderr)
+            self.assertIn("PyDevices branch", result.stderr)
+            self.assertEqual(lockfile.read_text(encoding="utf-8"), before)
+
+
 class SharedDescriptionTests(unittest.TestCase):
     def test_pydevices_manifest_uses_shared_description(self) -> None:
         text = sync.render_pydevices_manifest("pydevices", "1.2.3", ())