The CircuitPython copy manifest carries audiomodal's shared kernel - #90
Merged
Merged
Conversation
The coverage variant's makefile has listed shared/audioif_modal.c since audiomodal landed, and the manifest never copied it, so build_cp.sh died at "No rule to make target" for everyone - which is also why verify_dsp's three-way had no audiomodal CircuitPython binary to stop at. Found by the effects program's pin-move build on 2026-09-17, which copied the pair by hand.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
build_cp.sh --variant coveragehas been broken since audiomodal landed: the variant's makefile listsshared/audioif_modal.c, andcopy_manifest.txtnever copied it or its header, so the build dies at No rule to make target. That is also whyverify_dsp's three-way had noaudiomodalCircuitPython binary to stop at. Found on 2026-09-17 by the effects program's pin-move build, which copied the pair by hand to get a 10.3.0 build at3388df4. Two manifest lines; nothing else.