Skip to content

Commit 7828f81

Browse files
committed
Fix CI: test_pick_latest_release was silently hitting the real network
pick_download(v) was missing fetch=_fixture_fetch, so it fell through to a real HTTP fetch of the actual micropython.org board page instead of the test's fixture data. It happened to keep matching the hardcoded "1.28.0" expectation until upstream cut a real 1.29.0 release, which broke it here today -- unrelated to the doc-only previous commit that CI caught it on. 1.4s -> 0.02s confirms it's offline now.
1 parent 9dfc706 commit 7828f81

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

cli/tests/test_firmware_download.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,7 @@ def test_pick_latest_release(self):
115115
cat = load_catalog(fetch=_fixture_fetch, force=True)
116116
v = find_variant("ESP32_GENERIC", catalog=cat)
117117
assert v is not None
118-
chosen = pick_download(v)
118+
chosen = pick_download(v, fetch=_fixture_fetch)
119119
self.assertEqual(chosen["channel"], "release")
120120
self.assertIn("1.28.0", chosen["version"])
121121

0 commit comments

Comments
 (0)