Repository navigation
fix the Box indicator function - #228
Merged
Merged
Conversation
- old: (x > self.lower) & (x < self.upper): this is an open set, which violates the assumption of the convex projection - fix (x >= self.lower) & (x <= self.upper): this is a closed convex set. also add a test for this logic.
tttamaki
marked this pull request as ready for review
September 6, 2025 07:37
mrava87
self-requested a review
September 7, 2025 12:51
mrava87
requested changes
Sep 7, 2025
- move and change lines to be consistent with other tests
mrava87
approved these changes
Sep 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found a small bug.
(x > self.lower) & (x < self.upper)(x >= self.lower) & (x <= self.upper)Also I added a test for this.