Skip to content

fix the Box indicator function #228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mrava87 merged 2 commits into from
Sep 8, 2025
Merged

fix the Box indicator function #228

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cc887e9
fix the Box indicator function
tttamaki Sep 6, 2025
41e1968
fix test_Box()
tttamaki Sep 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pyproximal/proximal/Box.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ def __init__(
self.box = BoxProj(self.lower, self.upper)

def __call__(self, x: NDArray) -> bool:
return bool(np.all((x > self.lower) & (x < self.upper)))
return bool(np.all((x >= self.lower) & (x <= self.upper)))

@_check_tau
def prox(self, x: NDArray, tau: float) -> NDArray:
Expand Down
5 changes: 5 additions & 0 deletions pytests/test_projection.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,11 @@ def test_Box(par):
box = Box(-1, 1)
x = np.random.normal(0.0, 1.0, par["nx"]).astype(par["dtype"])

# evaluation
assert box(x) is False
xp = box.prox(x, 1.0)
assert box(xp) is True

# prox / dualprox
tau = 2.0
assert moreau(box, x, tau)
Expand Down