chore: clear review findings and drop console perf diagnostics

Resolve the type-aware review findings on main: describe the two no-control-regex disable directives in the login service, type the mapWithConcurrency result buffer with new Array<R>(), and document the custom-spawn double assertion (ChildProcess's nullable streams vs the SDK's non-nullable SpawnedProcess). The console-based [qoderian perf] timing diagnostics are removed outright because the review forbids disabling no-console and the lines were a developer-only nicety — the diagnostics module, its tests, and all measureAsync/measure/logElapsed call sites are unwrapped while the actual performance work stays. Local eslint now mirrors no-console (allow warn/error) and no-unnecessary-type-assertion at warn for src, keeping local lint aligned with the GitHub review.

Co-authored-by: QoderAI (Qwen 3.8 Max) <qoder_ai@qoder.com>

Author: luoxuanzao

eslint.config.mjs

@@ -131,7 +131,13 @@ export default defineConfig([
     plugins: {
       obsidianmd,
     },
-    rules: stagedObsidianRules,
+    rules: {
+      ...stagedObsidianRules,
+      // Mirrored from the type-aware review that runs on GitHub, so the
+      // matching disable directives stay meaningful in local lint too.
+      'no-console': ['warn', { allow: ['warn', 'error'] }],
+      '@typescript-eslint/no-unnecessary-type-assertion': 'warn',
+    },
   },
   // Layer boundaries. Arrows point inward to core: core depends on nobody,
   // qoder implements the core contracts. features may call into qoder

src/core/async/map-with-concurrency.ts

@@ -12,7 +12,7 @@ export async function mapWithConcurrency<T, R>(
   limit: number,
   mapper: (item: T, index: number) => Promise<R>,
 ): Promise<R[]> {
-  const results: R[] = new Array(items.length);
+  const results = new Array<R>(items.length);
   let nextIndex = 0;
 
   async function runWorker(): Promise<void> {

src/core/diagnostics/performance.ts

@@ -3,11 +3,6 @@ import { Notice } from 'obsidian';
 import { hasErrorContentBlock } from '../../../core/chat/error-blocks';
 import { detectBuiltInCommand } from '../../../core/commands/built-in-commands';
 import type { BrowserSelectionContext, CanvasSelectionContext } from '../../../core/context/types';
-import {
-  logElapsed,
-  measure,
-  measureAsync,
-} from '../../../core/diagnostics/performance';
 import type { EditorSelectionContext } from '../../../core/editor/editor-context';
 import type { ChatRuntime } from '../../../core/runtime/chat-runtime';
 import type { ApprovalCallbackOptions, ChatTurnRequest } from '../../../core/runtime/types';
@@ -282,13 +277,13 @@ export class InputController {
         displayContent: content,
         turnRequest: cloneChatTurnRequest(options.turnRequestOverride),
       }
-      : await measureAsync('turn.buildSubmission', () => this.buildTurnSubmission({
+      : await this.buildTurnSubmission({
         content,
         images: imagesForMessage,
         editorContextOverride: options?.editorContextOverride,
         browserContextOverride: options?.browserContextOverride,
         canvasContextOverride: options?.canvasContextOverride,
-      }));
+      });
     const { displayContent, turnRequest } = turnSubmission;
 
     fileContextManager?.markCurrentNoteSent();
@@ -305,7 +300,7 @@ export class InputController {
     state.hasPendingConversationSave = true;
     renderer.addMessage(userMsg);
 
-    await measureAsync('turn.titleGeneration', () => this.triggerTitleGeneration());
+    await this.triggerTitleGeneration();
 
     const assistantMsg: ChatMessage = {
       id: this.deps.generateId(),
@@ -330,9 +325,6 @@ export class InputController {
       isCompact ? 'qoderian-thinking--compact' : undefined,
     );
     state.responseStartTime = performance.now();
-    // Turn-level timing origin for the [qoderian perf] turn.* diagnostics.
-    const turnStartedAt = state.responseStartTime;
-    let sawFirstRuntimeChunk = false;
 
     let wasInterrupted = false;
     let wasInvalidated = false;
@@ -341,7 +333,7 @@ export class InputController {
 
     // Lazy initialization: ensure service is ready before first query
     if (this.deps.ensureServiceInitialized) {
-      const ready = await measureAsync('turn.serviceInit', () => this.deps.ensureServiceInitialized!());
+      const ready = await this.deps.ensureServiceInitialized();
       if (!ready) {
         new Notice('Failed to initialize agent service. Please try again.');
         streamController.hideThinkingIndicator();
@@ -384,7 +376,7 @@ export class InputController {
     }
 
     try {
-      const preparedTurn = measure('turn.prepareTurn', () => agentService.prepareTurn(turnRequest));
+      const preparedTurn = agentService.prepareTurn(turnRequest);
       userMsg.content = preparedTurn.persistedContent;
       userMsg.currentNote = preparedTurn.isCompact
         ? undefined
@@ -394,10 +386,6 @@ export class InputController {
       // This prevents duplication when rebuilding context for new sessions
       const previousMessages = state.messages.slice(0, -2);
       for await (const chunk of agentService.query(preparedTurn, previousMessages)) {
-        if (!sawFirstRuntimeChunk) {
-          sawFirstRuntimeChunk = true;
-          logElapsed('turn.firstChunk', turnStartedAt);
-        }
         if (state.streamGeneration !== streamGeneration) {
           wasInvalidated = true;
           break;
@@ -428,7 +416,6 @@ export class InputController {
         this.activeStreamingAssistantMessage ?? assistantMsg,
       );
     } finally {
-      logElapsed('turn.total', turnStartedAt);
       const finalAssistantMsg = this.activeStreamingAssistantMessage ?? assistantMsg;
       const turnMetadata = agentService.consumeTurnMetadata();
       userMsg.userMessageId = turnMetadata.userMessageId ?? userMsg.userMessageId;

src/features/chat/controllers/input-controller.ts

@@ -1,6 +1,5 @@
 import { Notice } from 'obsidian';
 
-import { measureAsync } from '../../../core/diagnostics/performance';
 import { reportRestoreIssue } from '../../../core/diagnostics/restore-report';
 import type { ChatRuntime } from '../../../core/runtime/chat-runtime';
 import { t } from '../../../i18n/i18n';
@@ -95,10 +94,7 @@ export class TabManager implements TabManagerInterface {
     tabId?: TabId,
     options: CreateTabOptions = {},
   ): Promise<TabData | null> {
-    return measureAsync(
-      this.isRestoringState ? 'tab.restore' : 'tab.create',
-      () => this.createTabInner(conversationId, tabId, options),
-    );
+    return this.createTabInner(conversationId, tabId, options);
   }
 
   private async createTabInner(
@@ -171,7 +167,7 @@ export class TabManager implements TabManagerInterface {
    * @param tabId The tab to switch to.
    */
   async switchToTab(tabId: TabId): Promise<void> {
-    return measureAsync('tab.switchTo', () => this.switchToTabInner(tabId));
+    return this.switchToTabInner(tabId);
   }
 
   private async switchToTabInner(tabId: TabId): Promise<void> {
@@ -545,7 +541,7 @@ export class TabManager implements TabManagerInterface {
 
   /** Restores state from persisted data. */
   async restoreState(state: PersistedTabManagerState): Promise<void> {
-    await measureAsync('startup.restoreTabs', () => this.restoreStateInner(state));
+    await this.restoreStateInner(state);
   }
 
   private async restoreStateInner(state: PersistedTabManagerState): Promise<void> {

src/features/chat/tabs/tab-manager.ts

@@ -6,7 +6,6 @@ import type { Editor, WorkspaceLeaf } from 'obsidian';
 import { addIcon, MarkdownView, Notice, Plugin } from 'obsidian';
 
 import { QoderianStorage } from './app/storage/app-storage';
-import { measureAsync } from './core/diagnostics/performance';
 import { beginRestoreReport, reportRestoreIssue } from './core/diagnostics/restore-report';
 import { buildCursorContext } from './core/editor/editor-context';
 import { getVaultPath } from './core/fs/path';
@@ -418,22 +417,10 @@ export default class QoderianPlugin extends Plugin {
     }
     const didNormalizeModelVariants = this.normalizeModelVariantSettings();
 
-    const allMetadata = await measureAsync(
-      'startup.listMetadata',
-      () => this.storage.sessions.listMetadata(),
-    );
-    const legacyLocations = await measureAsync(
-      'startup.probeLegacyEditions',
-      () => this.probeLegacyEditionLocations(allMetadata),
-    );
-    await measureAsync(
-      'startup.migrateLegacyEditions',
-      () => this.migrateLegacySessionEditions(allMetadata, legacyLocations),
-    );
-    this.conversations = await measureAsync(
-      'startup.buildConversationIndex',
-      () => this.buildConversationIndex(allMetadata, legacyLocations),
-    );
+    const allMetadata = await this.storage.sessions.listMetadata();
+    const legacyLocations = await this.probeLegacyEditionLocations(allMetadata);
+    await this.migrateLegacySessionEditions(allMetadata, legacyLocations);
+    this.conversations = await this.buildConversationIndex(allMetadata, legacyLocations);
     setLocale(this.settings.locale as Locale);
 
     if (didNormalizeModelVariants) {
@@ -590,12 +577,9 @@ export default class QoderianPlugin extends Plugin {
       return;
     }
 
-    await measureAsync(
-      'history.hydrateConversation',
-      () => historyService.hydrateConversationHistory(
-        conversation,
-        getVaultPath(this.app),
-      ),
+    await historyService.hydrateConversationHistory(
+      conversation,
+      getVaultPath(this.app),
     );
   }
 

src/main.ts

@@ -71,6 +71,7 @@ export function createCustomSpawnFunction(
       throw new Error('Failed to create process streams');
     }
 
+    // eslint-disable-next-line @typescript-eslint/no-unnecessary-type-assertion -- ChildProcess streams are nullable while SpawnedProcess requires them; the double assertion is the bridge TS cannot infer.
     return child as unknown as SpawnedProcess;
   };
 }

src/qoder/runtime/custom-spawn.ts

@@ -1,6 +1,5 @@
 import type { SDKUserMessage } from '@qoder-ai/qoder-agent-sdk';
 
-import { logElapsed } from '../../core/diagnostics/performance';
 import type { StreamChunk } from '../../core/types';
 import type { QoderMessageChannel } from './qoder-message-channel';
 import { isSessionExpiredError } from './session-context';
@@ -27,16 +26,9 @@ export async function* streamPersistentTurn(
     error: null as Error | null,
   };
   const handlerId = `handler-${Date.now()}-${Math.random().toString(36).slice(2)}`;
-  const enqueuedAt = performance.now();
-  let sawFirstChunk = false;
   const handler = createResponseHandler({
     id: handlerId,
     onChunk: chunk => {
-      if (!sawFirstChunk) {
-        sawFirstChunk = true;
-        // Covers CLI cold-start when the persistent Query was just spawned.
-        logElapsed('turn.enqueueToFirstChunk', enqueuedAt);
-      }
       handler.markChunkSeen();
       if (state.resolveChunk) {
         state.resolveChunk(chunk);

src/qoder/runtime/persistent-turn-stream.ts

@@ -23,10 +23,6 @@ import type {
 import { query as agentQuery } from '@qoder-ai/qoder-agent-sdk';
 import { Notice } from 'obsidian';
 
-import {
-  logElapsed,
-  measureAsync,
-} from '../../core/diagnostics/performance';
 import { getEnhancedPath, getMissingNodeError } from '../../core/env/environment';
 import { getVaultPath } from '../../core/fs/path';
 import type { ChatRuntime } from '../../core/runtime/chat-runtime';
@@ -149,8 +145,6 @@ export class QoderChatRuntime implements ChatRuntime {
   private persistentQuery: Query | null = null;
   private messageChannel: QoderMessageChannel | null = null;
   private queryAbortController: AbortController | null = null;
-  /** Set when the persistent Query is created; used to time CLI cold-start. */
-  private persistentQueryCreatedAt: number | null = null;
   private readonly responseRouter: QoderResponseRouter;
   private responseConsumerRunning = false;
   private responseConsumerPromise: Promise<void> | null = null;
@@ -425,13 +419,10 @@ export class QoderChatRuntime implements ChatRuntime {
       externalContextPaths
     );
 
-    const spawnStartedAt = performance.now();
     this.persistentQuery = agentQuery({
       prompt: this.messageChannel,
       options,
     });
-    logElapsed('runtime.spawnPersistentQuery', spawnStartedAt);
-    this.persistentQueryCreatedAt = performance.now();
 
     if (this.pendingResumeAt === resumeAtMessageId) {
       this.pendingResumeAt = undefined;
@@ -490,7 +481,6 @@ export class QoderChatRuntime implements ChatRuntime {
     this.persistentQuery = null;
     this.messageChannel = null;
     this.queryAbortController = null;
-    this.persistentQueryCreatedAt = null;
     this.responseConsumerRunning = false;
     this.responseConsumerPromise = null;
     this.currentConfig = null;
@@ -638,15 +628,7 @@ export class QoderChatRuntime implements ChatRuntime {
       if (!this.persistentQuery) return;
 
       try {
-        let sawFirstMessage = false;
         for await (const message of this.persistentQuery) {
-          if (!sawFirstMessage) {
-            sawFirstMessage = true;
-            if (this.persistentQueryCreatedAt !== null) {
-              // CLI cold-start: from Query creation to the first runtime message.
-              logElapsed('runtime.cliFirstMessage', this.persistentQueryCreatedAt);
-            }
-          }
           if (this.shuttingDown) break;
 
           await this.responseRouter.route(message);
@@ -964,7 +946,7 @@ export class QoderChatRuntime implements ChatRuntime {
     const savedPreapprovedTools = this.currentPreapprovedTools;
 
     // Apply dynamic updates before sending (Phase 1.6)
-    await measureAsync('runtime.applyDynamicUpdates', () => this.applyDynamicUpdates(queryOptions));
+    await this.applyDynamicUpdates(queryOptions);
 
     // Restore turn pre-approvals in case a dynamic update restarted the Query.
     this.currentPreapprovedTools = savedPreapprovedTools;

src/qoder/runtime/qoder-chat-runtime.ts

@@ -43,9 +43,9 @@ export interface QoderLoginController {
   reset(): void;
 }
 
-// eslint-disable-next-line no-control-regex
+// eslint-disable-next-line no-control-regex -- ANSI escapes start with the ESC control character, which the pattern must match to strip them.
 const ANSI_ESCAPE_PATTERN = /\u001b\[[0-9;]*[A-Za-z]/g;
-// eslint-disable-next-line no-control-regex
+// eslint-disable-next-line no-control-regex -- the URL match must stop at ESC so escape sequences never leak into the opened link.
 const AUTH_URL_PATTERN = /https?:\/\/[^\s\u001b]+/;
 const OUTPUT_TAIL_LIMIT = 2_000;
 const INITIAL_STATE: QoderLoginState = { phase: 'idle', authUrl: null, failure: null };