Add coefficient handler methods to python - #146
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds Python-level accessors for inspecting the generalized-tableau sparse coefficient vector (for debugging/monitoring), backed by new PyO3 bindings and covered by dedicated Python tests.
Changes:
- Exposes
GeneralizedTableau.coefficients()andGeneralizedTableau.num_coefficients()in the Python wrapper. - Implements the corresponding native methods in
ppvm-python-native(including lossless index conversion for widebnumindex types). - Adds a new Python test module validating snapshot semantics, normalization, and wide-index behavior.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| ppvm-python/src/ppvm/generalized_tableau.py | Adds the two convenience methods and their docstrings. |
| ppvm-python/src/ppvm/_core.pyi | Updates the native interface type stubs to include the new methods. |
| crates/ppvm-python-native/src/interface_tableau.rs | Adds PyO3 methods to export coefficients as a Python dict and to return the coefficient count. |
| ppvm-python/test/generalized_tableau/test_coefficients.py | Adds unit tests for the new API (fresh state, branching behavior, normalization, snapshot semantics, wide index types). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+203
to
+205
| This is the number of entries in the dict returned by | ||
| :meth:`coefficients`, computed without materializing it. | ||
|
|
Comment on lines
+62
to
+65
| # Past 128 qubits the Rust index is a bnum type; the keys must still | ||
| # round-trip as exact Python ints and the vector stay normalized. | ||
| tab = GeneralizedTableau(200) | ||
| tab.h(0) |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds two convenience methods to get the coefficients and their length to the python wrapper for
GeneralizedTableau. Useful for debugging and monitoring growth of the problem.