Repository navigation
perf(resources): change-gate ResourceEvent sends to stop per-tick spam - #2885
Merged
Merged
Conversation
server.updateResource and updateResourceToAllWithSpawnedEntity sent a ResourceEvent every call with no comparison to the last value sent, so the 3s resource tick re-sent decaying resources (hunger/hydration/endurance/comfort, and virus via virusBurnTick) every tick even though the raw change was too small to move the client-displayed bar. Track the last-sent value per resource on the character and only emit when the client- displayed value would change: quantize to permille of the resource MAX_VALUE, and always emit exact empty/full transitions. Non-player entities (vehicles/doors/construction) are never gated, so their behavior is unchanged. The cache is reset in resetResources so respawn/resync always resends; a freshly-created character starts with an empty cache. Net: a steady-state character emits ~0 ResourceEvents; real changes (damage, eating, drinking, healing, decay crossing a visible step) still send. Permille granularity is a conservative floor pending RE confirmation of the client's real bar resolution.
QuentinGruber
approved these changes
Aug 24, 2026
johnoclockdk
approved these changes
Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
server.updateResource and updateResourceToAllWithSpawnedEntity sent a ResourceEvent every call with no comparison to the last value sent, so the 3s resource tick re-sent decaying resources (hunger/hydration/endurance/comfort, and virus via virusBurnTick) every tick even though the raw change was too small to move the client-displayed bar.
Track the last-sent value per resource on the character and only emit when the client- displayed value would change: quantize to permille of the resource MAX_VALUE, and always emit exact empty/full transitions. Non-player entities (vehicles/doors/construction) are never gated, so their behavior is unchanged. The cache is reset in resetResources so respawn/resync always resends; a freshly-created character starts with an empty cache.
Net: a steady-state character emits ~0 ResourceEvents; real changes (damage, eating, drinking, healing, decay crossing a visible step) still send. Permille granularity is a conservative floor pending RE confirmation of the client's real bar resolution.