Repository navigation
Commit 2b73435
fix(filter-v2): a boolean column is a predicate on its own
`WHERE flag` and `WHERE NOT flag` were rejected at decode with "predicate
root must resolve to BOOLEAN". DuckDB pushes such a predicate down as a bare
`column_ref` rather than rewriting it to `flag = true`, and the schema admits
that -- `coreExpression` lists `columnRef` first -- so the decoder was
stricter than its own published contract, and the idiomatic form of the
commonest boolean predicate there is failed for every worker.
Three things, each independently wrong:
- `FilterParser._is_boolean` enumerated node *kinds* believed to be boolean
instead of asking for the resolved *type*. The two agree for every node
whose type is structurally fixed -- a comparison is BOOLEAN whatever its
operands -- which is why the enumeration looked sufficient. It is not:
`column_ref`, `field_ref`, `cast` and `arithmetic` are BOOLEAN or not
depending on a type resolved from elsewhere, and all four were refused.
The parser had *already* resolved the column against the bind output
schema and stored the type on the node; a sibling helper written in the
same commit, `expression_type()`, reads it correctly and is used one
branch away to type-check `field_ref`. Call it here too.
- A bare boolean column left as a generic v2 expression becomes a
`V2ExpressionFilter`, which evaluates but renders no SQL -- so a SQL-backed
worker silently lost pushdown on it, and on a conjunction containing one it
lost pushdown for the whole conjunction. `_v2_filter_view` now projects
`flag` and `NOT flag` onto the legacy equality leaf. The rewrite is exact
under three-valued logic: `WHERE flag` keeps only TRUE and so does
`flag = true`; `WHERE NOT flag` keeps only FALSE and so does `flag = false`.
An unresolved or non-boolean column is left alone rather than guessed at.
- `to_sql()` raised a bare `ValueError: Unknown filter type` on anything the
legacy projection could not reduce. It now raises
`FilterSQLUnsupportedError` naming the node and pointing at `apply()`.
It still raises rather than skipping, deliberately: DuckDB does **not**
re-apply a predicate it pushed into a table function -- measured, not
assumed: a scan that ignores its WHERE returns 3255 rows where the
predicate admits 1874 -- so a quietly dropped filter is a wrong answer, not
a slow one.
Nothing covered this. The cross-port conformance corpus has no bare boolean
column case, and the extension's own `filter_pushdown/booleans.test` -- added
to close a boolean coverage gap -- writes every predicate as `b = true`,
`b != true` or `b IN (...)`, never `WHERE b`. Tests added here for both
forms, for a conjunction containing one, for the SQL they must render, for
the refusal of an unresolved or non-boolean column, and for the no-silent-
drop guarantee.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>1 parent 9aa90f6 commit 2b73435
3 files changed
Lines changed: 263 additions & 7 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
9 | | - | |
| 9 | + | |
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
| |||
531 | 531 | | |
532 | 532 | | |
533 | 533 | | |
| 534 | + | |
| 535 | + | |
| 536 | + | |
| 537 | + | |
| 538 | + | |
| 539 | + | |
| 540 | + | |
| 541 | + | |
| 542 | + | |
| 543 | + | |
| 544 | + | |
| 545 | + | |
| 546 | + | |
| 547 | + | |
| 548 | + | |
| 549 | + | |
| 550 | + | |
| 551 | + | |
| 552 | + | |
| 553 | + | |
| 554 | + | |
| 555 | + | |
| 556 | + | |
| 557 | + | |
| 558 | + | |
| 559 | + | |
| 560 | + | |
| 561 | + | |
| 562 | + | |
| 563 | + | |
| 564 | + | |
| 565 | + | |
| 566 | + | |
| 567 | + | |
| 568 | + | |
| 569 | + | |
| 570 | + | |
| 571 | + | |
| 572 | + | |
| 573 | + | |
| 574 | + | |
| 575 | + | |
| 576 | + | |
| 577 | + | |
| 578 | + | |
| 579 | + | |
| 580 | + | |
| 581 | + | |
| 582 | + | |
| 583 | + | |
| 584 | + | |
| 585 | + | |
| 586 | + | |
| 587 | + | |
| 588 | + | |
| 589 | + | |
| 590 | + | |
| 591 | + | |
| 592 | + | |
| 593 | + | |
| 594 | + | |
| 595 | + | |
| 596 | + | |
| 597 | + | |
| 598 | + | |
| 599 | + | |
| 600 | + | |
| 601 | + | |
| 602 | + | |
| 603 | + | |
| 604 | + | |
| 605 | + | |
| 606 | + | |
| 607 | + | |
| 608 | + | |
| 609 | + | |
| 610 | + | |
| 611 | + | |
| 612 | + | |
| 613 | + | |
| 614 | + | |
| 615 | + | |
| 616 | + | |
| 617 | + | |
| 618 | + | |
| 619 | + | |
| 620 | + | |
| 621 | + | |
| 622 | + | |
| 623 | + | |
| 624 | + | |
| 625 | + | |
| 626 | + | |
| 627 | + | |
| 628 | + | |
| 629 | + | |
| 630 | + | |
| 631 | + | |
| 632 | + | |
| 633 | + | |
| 634 | + | |
| 635 | + | |
| 636 | + | |
| 637 | + | |
| 638 | + | |
| 639 | + | |
| 640 | + | |
| 641 | + | |
| 642 | + | |
| 643 | + | |
| 644 | + | |
| 645 | + | |
| 646 | + | |
| 647 | + | |
| 648 | + | |
| 649 | + | |
| 650 | + | |
| 651 | + | |
| 652 | + | |
| 653 | + | |
| 654 | + | |
| 655 | + | |
| 656 | + | |
| 657 | + | |
| 658 | + | |
| 659 | + | |
| 660 | + | |
| 661 | + | |
| 662 | + | |
| 663 | + | |
| 664 | + | |
| 665 | + | |
| 666 | + | |
| 667 | + | |
| 668 | + | |
| 669 | + | |
| 670 | + | |
| 671 | + | |
| 672 | + | |
| 673 | + | |
| 674 | + | |
| 675 | + | |
| 676 | + | |
| 677 | + | |
| 678 | + | |
| 679 | + | |
| 680 | + | |
| 681 | + | |
| 682 | + | |
| 683 | + | |
| 684 | + | |
| 685 | + | |
| 686 | + | |
| 687 | + | |
| 688 | + | |
| 689 | + | |
| 690 | + | |
| 691 | + | |
| 692 | + | |
| 693 | + | |
| 694 | + | |
| 695 | + | |
| 696 | + | |
| 697 | + | |
| 698 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
740 | 740 | | |
741 | 741 | | |
742 | 742 | | |
743 | | - | |
744 | | - | |
745 | | - | |
746 | | - | |
747 | | - | |
| 743 | + | |
| 744 | + | |
| 745 | + | |
| 746 | + | |
| 747 | + | |
| 748 | + | |
| 749 | + | |
| 750 | + | |
| 751 | + | |
| 752 | + | |
| 753 | + | |
| 754 | + | |
| 755 | + | |
| 756 | + | |
| 757 | + | |
| 758 | + | |
| 759 | + | |
| 760 | + | |
748 | 761 | | |
749 | 762 | | |
750 | 763 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
63 | 63 | | |
64 | 64 | | |
65 | 65 | | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
66 | 69 | | |
67 | 70 | | |
68 | 71 | | |
| |||
72 | 75 | | |
73 | 76 | | |
74 | 77 | | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
75 | 81 | | |
76 | 82 | | |
77 | 83 | | |
| |||
207 | 213 | | |
208 | 214 | | |
209 | 215 | | |
| 216 | + | |
210 | 217 | | |
211 | 218 | | |
212 | 219 | | |
| |||
1638 | 1645 | | |
1639 | 1646 | | |
1640 | 1647 | | |
| 1648 | + | |
| 1649 | + | |
| 1650 | + | |
| 1651 | + | |
| 1652 | + | |
| 1653 | + | |
| 1654 | + | |
| 1655 | + | |
| 1656 | + | |
| 1657 | + | |
| 1658 | + | |
| 1659 | + | |
| 1660 | + | |
| 1661 | + | |
| 1662 | + | |
| 1663 | + | |
1641 | 1664 | | |
1642 | 1665 | | |
1643 | 1666 | | |
| |||
1713 | 1736 | | |
1714 | 1737 | | |
1715 | 1738 | | |
| 1739 | + | |
| 1740 | + | |
| 1741 | + | |
| 1742 | + | |
| 1743 | + | |
| 1744 | + | |
| 1745 | + | |
| 1746 | + | |
| 1747 | + | |
| 1748 | + | |
| 1749 | + | |
1716 | 1750 | | |
1717 | | - | |
| 1751 | + | |
1718 | 1752 | | |
1719 | 1753 | | |
1720 | 1754 | | |
| |||
1787 | 1821 | | |
1788 | 1822 | | |
1789 | 1823 | | |
| 1824 | + | |
| 1825 | + | |
| 1826 | + | |
| 1827 | + | |
| 1828 | + | |
| 1829 | + | |
| 1830 | + | |
| 1831 | + | |
| 1832 | + | |
| 1833 | + | |
| 1834 | + | |
| 1835 | + | |
| 1836 | + | |
| 1837 | + | |
| 1838 | + | |
| 1839 | + | |
| 1840 | + | |
| 1841 | + | |
| 1842 | + | |
| 1843 | + | |
| 1844 | + | |
| 1845 | + | |
| 1846 | + | |
| 1847 | + | |
| 1848 | + | |
| 1849 | + | |
| 1850 | + | |
| 1851 | + | |
| 1852 | + | |
| 1853 | + | |
| 1854 | + | |
| 1855 | + | |
| 1856 | + | |
| 1857 | + | |
| 1858 | + | |
| 1859 | + | |
| 1860 | + | |
| 1861 | + | |
| 1862 | + | |
| 1863 | + | |
| 1864 | + | |
| 1865 | + | |
1790 | 1866 | | |
1791 | 1867 | | |
1792 | 1868 | | |
| |||
1802 | 1878 | | |
1803 | 1879 | | |
1804 | 1880 | | |
| 1881 | + | |
| 1882 | + | |
1805 | 1883 | | |
1806 | 1884 | | |
1807 | 1885 | | |
| |||
0 commit comments