Skip to content

Commit 6e0301a

Browse files
rustyconoverclaude
andcommitted
ci: skip cache/revalidate.test on the http lane (subprocess-only)
The result cache's conditional revalidation (304 / not_modified) is subprocess-only by design: the if_none_match validator rides the first producer tick, but over HTTP that first exchange folds into the /init POST before any tick is sent, so the not_modified path never fires and the worker is re-invoked. revalidate.test asserts a revalidation HIT (stable nonce), which then fails over HTTP. The test deliberately omits `require httpfs` so it auto-skips under a plain HTTP harness, but this CI lane force-injects `LOAD httpfs` before each ATTACH, defeating that auto-skip and running the test over HTTP. Add it to the http-lane EXTRA_SKIP alongside the other known-HTTP limitations. The launch/stdio/shm lanes still run it. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
1 parent 08c25eb commit 6e0301a

1 file changed

Lines changed: 7 additions & 0 deletions

File tree

‎ci/run-integration.sh‎

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -73,11 +73,18 @@ if [ "$TRANSPORT" = "http" ]; then
7373
# * buffer_input/sizes.test — input buffering semantics differ over HTTP
7474
# (same known limitation). (scale.test_slow is a .test_slow file and is
7575
# never staged below, which only finds *.test.)
76+
# * cache/revalidate.test — conditional revalidation (304) is subprocess-only:
77+
# the if_none_match validator rides the first producer tick, but over HTTP
78+
# that first exchange folds into the /init POST before any tick, so the
79+
# not_modified path can't fire (documented in the test header + vgi CLAUDE.md).
80+
# The test omits `require httpfs` to auto-skip under a plain HTTP harness, but
81+
# this lane force-injects `LOAD httpfs`, defeating that — so drop it explicitly.
7682
EXTRA_SKIP=(
7783
-not -name 'projection_pushdown_repro.test'
7884
-not -name 'dynamic_filter.test'
7985
-not -name 'partitioned_sequence.test'
8086
-not -path './table_in_out/buffer_input/sizes.test'
87+
-not -name 'revalidate.test'
8188
)
8289
fi
8390

0 commit comments

Comments
 (0)