Repository navigation
Commit 798fc31
splits: type the canonical filter renderer instead of taking
_render_filters_canonical took `object`, so mypy rejected every attribute
access on it and the repo's own test_mypy_vgi_clean check failed. Typing the
parameter as PushdownFilters (under TYPE_CHECKING, to keep the import cost off
the runtime path) fixes both accesses.
The bound values are pyarrow Scalars, which support int() at runtime but not to
the type checker, so _bound_as_int unwraps through as_py first — which is also
clearer about what is happening than relying on Scalar.__int__.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>object
1 parent 2ad2ad2 commit 798fc31
2 files changed
Lines changed: 18 additions & 4 deletions
Binary file not shown.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
28 | 28 | | |
29 | 29 | | |
30 | 30 | | |
31 | | - | |
| 31 | + | |
32 | 32 | | |
33 | 33 | | |
34 | 34 | | |
| |||
40 | 40 | | |
41 | 41 | | |
42 | 42 | | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
43 | 46 | | |
44 | 47 | | |
45 | 48 | | |
| |||
1079 | 1082 | | |
1080 | 1083 | | |
1081 | 1084 | | |
1082 | | - | |
| 1085 | + | |
| 1086 | + | |
| 1087 | + | |
| 1088 | + | |
| 1089 | + | |
| 1090 | + | |
| 1091 | + | |
| 1092 | + | |
| 1093 | + | |
| 1094 | + | |
| 1095 | + | |
| 1096 | + | |
1083 | 1097 | | |
1084 | 1098 | | |
1085 | 1099 | | |
| |||
1106 | 1120 | | |
1107 | 1121 | | |
1108 | 1122 | | |
1109 | | - | |
| 1123 | + | |
1110 | 1124 | | |
1111 | 1125 | | |
1112 | | - | |
| 1126 | + | |
1113 | 1127 | | |
1114 | 1128 | | |
1115 | 1129 | | |
| |||
0 commit comments