Skip to content

Emit typed Responses failure events for generation errors - #51

Merged
ehartford merged 5 commits into
fix/responses-incomplete-toolsfrom
fix/responses-generation-errors
Oct 15, 2026
Merged

ehartford merged 5 commits into
fix/responses-incomplete-toolsfrom
fix/responses-generation-errors

Conversation

@ropoctl

@ropoctl ropoctl commented Sep 19, 2026

Copy link
Copy Markdown
Contributor

Preserve the original generation or finalization error in a typed response.failed event and stored response, with monotonic event sequence numbers.

Validation: Eight generation-error SSE/storage cases and 23 inherited completion tests passed on CPU.

Stack base: #50. This PR contains one new commit.

Combined current-main check: all 26 prepared code/tooling branches applied together; 295 tests passed, eight XPU tests skipped, and 22 proxy/auditor fixtures passed. Hardware/model qualification remains as stated above.

@coderabbitai

coderabbitai Bot commented Sep 19, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 59 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 7c1f4a7e-0329-4432-bf46-6ccb6eb648f1
📥 Commits

Reviewing files that changed from the base of the PR and between de9da50 and f4d2103.

📒 Files selected for processing: 3
  • perf/optimization_status.md
  • tests/entrypoints/test_responses_stream_generation_error.py
  • vllm/entrypoints/openai/responses/serving.py
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ropoctl
ropoctl added this pull request to stack #74 September 19, 2026 23:55
@ehartford
ehartford merged commit 470a782 into main Oct 15, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants