Clean client rendering on RenderStatus change

Author: NicEastvillage

RLBotCS/Server/FlatBuffersSession.cs

@@ -35,7 +35,7 @@ public readonly record struct DistributeBallPrediction(BallPredictionT BallPredi
 
     public readonly record struct StopMatch(bool Force) : SessionMessage;
 
-    public readonly record struct UpdateRendering(RenderingStatusT Status) : SessionMessage;
+    public readonly record struct UpdateRenderingStatus(RenderingStatusT Status) : SessionMessage;
 
     public readonly record struct PingResponse(ulong Cookie) : SessionMessage;
 }
@@ -312,7 +312,7 @@ await _bridge.WriteAsync(
 
             case InterfaceMessage.RenderingStatus:
                 var renderingStatus = msg.MessageAsRenderingStatus().UnPack();
-                await _rlbotServer.WriteAsync(new UpdateRendering(renderingStatus));
+                await _rlbotServer.WriteAsync(new UpdateRenderingStatus(renderingStatus));
                 break;
 
             case InterfaceMessage.UpdatePerformanceMonitor:
@@ -430,7 +430,7 @@ private async Task HandleInternalMessages()
                     when m.Force || (_connectionEstablished && _closeBetweenMatches):
                     _sessionForceClosed = m.Force;
                     return;
-                case SessionMessage.UpdateRendering m:
+                case SessionMessage.UpdateRenderingStatus m:
                     if (_team == Team.Other)
                     {
                         SendPayloadToClient(CoreMessageUnion.FromRenderingStatus(m.Status));
@@ -444,6 +444,11 @@ private async Task HandleInternalMessages()
                     {
                         _renderingIsEnabled = m.Status.Status;
                         SendPayloadToClient(CoreMessageUnion.FromRenderingStatus(m.Status));
+
+                        if (!_renderingIsEnabled)
+                        {
+                            await _bridge.WriteAsync(new RemoveClientRenders(_clientId));
+                        }
                     }
 
                     break;

…/Server/ServerMessage/UpdateRendering.cs …r/ServerMessage/UpdateRenderingStatus.csRLBotCS/Server/ServerMessage/UpdateRendering.cs renamed to RLBotCS/Server/ServerMessage/UpdateRenderingStatus.cs RLBotCS/Server/ServerMessage/UpdateRendering.cs renamed to RLBotCS/Server/ServerMessage/UpdateRenderingStatus.cs

@@ -2,15 +2,15 @@
 
 namespace RLBotCS.Server.ServerMessage;
 
-readonly struct UpdateRendering(RenderingStatusT Status) : IServerMessage
+readonly struct UpdateRenderingStatus(RenderingStatusT Status) : IServerMessage
 {
     public ServerAction Execute(ServerContext context)
     {
         // Ignore all messages if rendering is force-disabled
         if (context.RenderingIsEnabled == DebugRendering.AlwaysOff)
             return ServerAction.Continue;
 
-        SessionMessage.UpdateRendering message = new(Status);
+        SessionMessage.UpdateRenderingStatus message = new(Status);
 
         // Distribute to all sessions;
         // they will figure out on their own if rendering should be enable/disabled