feat(rocprim) Replace index-based test filters in rtest.xml by names

[amd-hsong]

Motivation

This PR replaces index-based test filters in rocPRIM's rtest.xml by names.

JIRA ID: AIPRIMS-221

Technical Details

Using numerical indices for test filters has consistency issues when test cases are removed/added/re-ordered as they won't refer to the same tests anymore. To remove/replace these indices, two mechanisms are used:

Mechanism A — full-range collapse to a wildcard (no source change)

When a filter enumerates the entire instantiation range of a suite/test, the whole enumeration is replaced with a single * wildcard. This is valid only when the enumerated indices equal the complete instantiation set.

Example: the Select large-input test has 5 parameter values (0..4), and SMOKE selected all of them for both test methods:

# before — 10 numeric tokens
RocprimDeviceSelectLargeInputFlaggedTest/*.LargeInputFlagged/0
RocprimDeviceSelectLargeInputFlaggedTest/*.LargeInputFlagged/1
... /2 /3 /4
RocprimDeviceSelectLargeInputFlaggedTest/*.LargeInputUnique/0
... /1 /2 /3 /4

# after — 2 wildcards, no source edit
RocprimDeviceSelectLargeInputFlaggedTest/*.LargeInputFlagged/*
RocprimDeviceSelectLargeInputFlaggedTest/*.LargeInputUnique/*

The same mechanism collapses full typed ranges elsewhere, e.g. RocprimDeviceRadixSort/0..N.SortKeys → RocprimDeviceRadixSort/*.SortKeys.

Mechanism B — name generator for partial selection (source change)

When a filter selects a subset of a suite's instantiations, the index cannot simply be dropped. Instead we give each instantiation a stable, attribute-derived name and filter on that name.

B1 — typed suites (TYPED_TEST_SUITE). A generator functor derives a readable name from the type parameters and is passed as the suite's name generator; the filter then references the name instead of the position. Example (warp-reduce family):

# before: 489 numeric patterns (SMOKE) enumerating type positions
WarpReduceTestsIntegral/0.ReduceSum* : WarpReduceTestsIntegral/1.* : ...

# after: names derived from warp_params<int,4u,1u> -> "Int_w4_i1"
WarpReduceTestsIntegral/*
  -WarpReduceTestsIntegral/Int_w4_i1.ReduceSum : -WarpReduceTestsIntegral/Int_w4_i1.ReduceSumValid

B2 — value-parameterized suites (INSTANTIATE_TEST_SUITE_P). A free naming function is supplied as the 4th argument of INSTANTIATE_TEST_SUITE_P; it maps each TestParamInfo to a [A-Za-z0-9_]-safe name. Example (partition large-input) — the param is std::pair<size_t /*size*/, bool /*use_graphs*/>:

INSTANTIATE_TEST_SUITE_P(
    RocprimDevicePartitionLargeInputTest,
    RocprimDevicePartitionLargeInputTests,
    ::testing::Values(std::make_pair(2, false),      // -> Size2
                      std::make_pair(2048, false),   // -> Size2048
                      std::make_pair(38713, false),  // -> Size38713
                      std::make_pair(38713, true)),  // -> Size38713Graphs
    [](const ::testing::TestParamInfo<RocprimDevicePartitionLargeInputTests::ParamType>& info)
    {
        std::string name = "Size" + std::to_string(std::get<0>(info.param));
        if(std::get<1>(info.param))
            name += "Graphs";
        return name;
    });

# before                                                    # after
.../LargeInputPartition/0            ->  .../LargeInputPartition/Size2
.../LargeInputPartition/1            ->  .../LargeInputPartition/Size2048
.../LargeInputPartitionThreeWay/1    ->  .../LargeInputPartitionThreeWay/Size2048
.../LargeInputPartitionThreeWay/2    ->  .../LargeInputPartitionThreeWay/Size38713
.../LargeInputPartitionThreeWay/3    ->  .../LargeInputPartitionThreeWay/Size38713Graphs
.../LargeInputPartitionTwoWay/1      ->  .../LargeInputPartitionTwoWay/Size2048

Residual indices

A small set of numeric indices is intentionally kept, because they cannot be replaced by any type-derived name.

The name generator derives an instance's name from its C++ type. When two instantiations inside one suite resolve to the identical type, both would generate the identical name — and GoogleTest requires instance names to be unique within a suite (a duplicate name is a hard build error). So no type-derived name can distinguish them; only the numeric position can. This is a blocker only when a filter treats the duplicates differently (selects one but not the other, or excludes different test methods from each).

Example — RocprimDeviceTransformTests index 5 vs index 9. On the LP64 platform the type list contains both unsigned long and uint64_t, which are the same underlying type, so both instantiations print byte-for-byte identically:

index 5:  DeviceTransformParams<unsigned long, unsigned long, false, 4294967295u, false>
index 9:  DeviceTransformParams<unsigned long, unsigned long, false, 4294967295u, false>

A generator would emit the same name for both (build failure), and the filters select them differently — so these tokens stay numeric. The below table shows all the residual indices in rtest.xml after the changes of this PR:

Suite (as it appears in filters)	Indices still referenced	Reason (same-type duplicate)
RocprimDeviceScanTests / DeviceScanTests / ScanTests	0,1..31 (per var)	idx 25 == idx 28 both custom_type<int,int>; SMOKE_OLD excludes different test methods from each
RocprimDeviceTransformTests / TransformTests / DeviceTransformTests	0,3,4,7,8,9,11,12,15	unsigned long == uint64_t (idx 5 == idx 9)
TypedRadixKeyCodecTest	0..14	int8_t==signed char, int16_t==short, uint16_t==unsigned short
RocprimCountingIteratorTests	0..3	unsigned long == size_t
RocprimDeviceNthelementTests	15	signed char == int8_t

Everything else that was type-derivable has been converted.

Test Plan

1. Make sure the existing test filters in test_categories.yaml continue working as before;

2. Test filters in rtest.xml refer to exactly the same set as before the changes, i.e.,

python3 rtest.py -t smoke

runs the same set of tests as before. Same for -t extended and -t regression as well.

Test Result

Confirmed test filters in test_categories.yaml and rtest.xml stay exactly the same.

Submission Checklist

• Look over the contributing guidelines at https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests.

[therock-pr-bot]

✅ All Checks Passed — Ready for Review

Check	Status	Details
📝 PR Description	✅ Pass	—
⛔ Forbidden Files	✅ Pass	—
🧪 Unit Test	✅ Pass	PR does not contain code files — Unit Test auto-passed
🔎 pre-commit	✅ Pass	—
🚫 Draft PR	🔜 To Be Enabled	—
🚩 Feature Flag	🔜 To Be Enabled	—
📊 Code Coverage	🔜 To Be Enabled	—
🤖 therock-pr-bot	✅ Pass	—

🎉 All checks passed! This PR is ready for review.

📖 Need help? See the Policy FAQ for details on every check and how to fix failures.

🙋 Wish to Override Policy?

[therock-pr-bot]

🎉 All checks passed! This PR is ready for review.

[stanleytsang-amd]

@amd-hsong There are build failures in CI:

[rocPRIM_tests] In file included from C:/home/runner/_work/rocm-libraries/rocm-libraries/external-rocm-libraries/projects/rocprim/test/rocprim/test_thread_algos.cpp:38:
[rocPRIM_tests] C:/home/runner/_work/rocm-libraries/rocm-libraries/external-rocm-libraries/projects/rocprim/test/rocprim\test_utils_types.hpp:345:23: error: static assertion failed due to requirement 'dependent_false<common::custom_type<unsigned long long, unsigned long long, true>>::value': type_tag: add a case for this type
[rocPRIM_tests]   345 |         static_assert(dependent_false<T>::value, "type_tag: add a case for this type");
[rocPRIM_tests]       |                       ^~~~~~~~~~~~~~~~~~~~~~~~~
[rocPRIM_tests] C:/home/runner/_work/rocm-libraries/rocm-libraries/external-rocm-libraries/projects/rocprim/test/rocprim/test_thread_algos.cpp:91:16: note: in instantiation of function template specialization 'type_tag<common::custom_type<unsigned long long, unsigned long long, true>>' requested here
[rocPRIM_tests]    91 |         return type_tag<typename Params::type>();
[rocPRIM_tests]       |                ^
[rocPRIM_tests] B:/build/third-party/googletest/dist/include\gtest/internal/gtest-internal.h:668:45: note: in instantiation of function template specialization 'RocprimThreadOperationTestsNameGenerator::GetName<params<common::custom_type<unsigned long long, unsigned long long, true>>>' requested here
[rocPRIM_tests]   668 |   result->push_back(NameGenerator::template GetName<typename Types::Head>(i));
[rocPRIM_tests]       |                                             ^
[rocPRIM_tests] B:/build/third-party/googletest/dist/include\gtest/internal/gtest-internal.h:669:3: note: in instantiation of function template specialization 'testing::internal::GenerateNamesRecursively<RocprimThreadOperationTestsNameGenerator, testing::internal::Types<params<common::custom_type<unsigned long long, unsigned long long, true>>, params<common::custom_type<double, double, true>>, params<unsigned __int128>>>' requested here
[rocPRIM_tests]   669 |   GenerateNamesRecursively<NameGenerator>(typename Types::Tail(), result,

[amd-hsong]

@stanleytsang-amd The Windows build failure has been fixed.

[amd-jmahovsky]

One question.

[amd-jmahovsky]

LGTM