Conversation
Convolution kernels moved from rocke/platform/ to rocke/library/ in #11978, where no rocKE label glob reaches. A conv PR touching only that layer now carries no rocKE subteam label at all -- #11888 is the live example. Adds a rocke-lib: conv rule mirroring the rocke-lib: attention rule added in #10040, so the convolution authors get the same live watch-queue the attention authors have. CODEOWNERS is deliberately unchanged: rocke/library/ already resolves to @ROCm/rocke-lib, which contains the convolution authors, so review routing is already correct. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
github-actions
Bot
added
github actions
project: none
✅ All Checks Passed — Ready for Review
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
|
🎉 All checks passed! This PR is ready for review. |
The label has now been created in the repo as "rocke-lib: convolution" -- spelled out rather than abbreviated. actions/labeler matches the label by exact name, so the rule key has to match it or nothing is applied. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
afagaj
changed the title
afagaj
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rocke-lib: convolutionlabel matching convolution sources underdnn-providers/hip-kernel-provider/rocke/library/, mirroring therocke-lib: attentionrule added in ci: scope rocKE library ownership and add attention label #10040.Modeled on #10099, which did the equivalent for
rocke: platform.Why
#11978 moved every convolution kernel builder, dispatch policy, test, parity emitter, benchmark and builder harness from
rocke/platform/torocke/library/. The existing globs are:rocke-lib: attention→rocke/library/**matching*attention*/*fmha*/*sdpa*rocke: platform→rocke/platform/**,rocke/style/**Convolution matches neither once it lives under
library/, so a conv PR touching only the moved layer carries no rocKE subteam label at all.Example: #11888 (merged 2026-09-10) changed exactly one file —
rocke/library/dispatch/grouped_convolution.py— and carries onlyorganization: ROCmandproject: hip-kernel-provider.Why CODEOWNERS is untouched
.github/CODEOWNERSalready routes the library tree:rocm-libraries/.github/CODEOWNERS
Line 20 in bc358d8
@ROCm/rocke-lib contains all three convolution authors — @bartekxk, @jakpiase, @aledudek — so review of conv changes under
library/is already routed correctly. Subdividing @ROCm/rocke-lib into attention- and convolution-specific GitHub teams may be considered in the future.This PR is about labelling, not ownership.
Validation
Globs evaluated with minimatch semantics (
**spans separators,*does not) against real PR file lists:rocke-lib: convolutionrocke-lib: convolution,rocke: platformrocke-lib: convolution,rocke-lib: attention,rocke: platformAgainst 13 attention/MLA PRs (#9017 #9040 #9087 #9098 #9190 #9220 #9267 #9392 #9442 #9462 #9496 #10005 #11627),
rocke-lib: convolutionfired on none.Of 344 tracked files under
rocke/library/: 59 matchrocke-lib: convolution, 143 matchrocke-lib: attention, 0 match both.*implicit_gemm*and*img2col*are included because #11978 moved files such asbake_off_implicit_gemm.pyandimg2col_emit.pythat a narrower*conv*/*wgrad*/*dgrad*list would miss.Scope
The labeler fires on
pull_request_targetevents only, so this cannot retro-label #11888 or any earlier conv PR. Backfilling existing history is handled separately on the reporting side.🤖 Generated with Claude Code