Skip to content

tensilelite: add per-tensor LDSTrInstA/LDSTrInstB overrides - #12177

Draft
leowu2017 wants to merge 1 commit into
developfrom
users/leowu/ldstr-ab
Draft

leowu2017 wants to merge 1 commit into
developfrom
users/leowu/ldstr-ab

Conversation

@leowu2017

Copy link
Copy Markdown
Contributor

Add LDSTrInstA and LDSTrInstB solution parameters that let each tensor (A/B) independently override the global LDSTrInst (LDS transpose instruction) setting. Both default to -1 ("not specified"), meaning they follow LDSTrInst, matching the existing NonTemporal/TemporalHint per-tensor override convention.

  • Common/ValidParameters.py: register LDSTrInstA/LDSTrInstB with valid values [-1, False, True].
  • Common/GlobalParameters.py: default both to -1 in defaultBenchmarkCommonParameters.
  • SolutionStructs/Solution.py: resolve LDSTrInstA/LDSTrInstB from -1 to LDSTrInst early in assignDerivedParameters, and use the resolved per-tensor values (instead of the global LDSTrInst) when deriving enableLDSTrA/enableLDSTrB and in the other three call sites that previously read the global LDSTrInst directly (LocalReadVectorWidthA/B checks and the ExpandPointerSwap reject).

Motivation

Technical Details

Test Plan

Test Result

Submission Checklist

Add LDSTrInstA and LDSTrInstB solution parameters that let each tensor
(A/B) independently override the global LDSTrInst (LDS transpose
instruction) setting. Both default to -1 ("not specified"), meaning
they follow LDSTrInst, matching the existing NonTemporal/TemporalHint
per-tensor override convention.

- Common/ValidParameters.py: register LDSTrInstA/LDSTrInstB with valid
  values [-1, False, True].
- Common/GlobalParameters.py: default both to -1 in
  defaultBenchmarkCommonParameters.
- SolutionStructs/Solution.py: resolve LDSTrInstA/LDSTrInstB from -1 to
  LDSTrInst early in assignDerivedParameters, and use the resolved
  per-tensor values (instead of the global LDSTrInst) when deriving
  enableLDSTrA/enableLDSTrB and in the other three call sites that
  previously read the global LDSTrInst directly (LocalReadVectorWidthA/B
  checks and the ExpandPointerSwap reject).
@therock-pr-bot

Copy link
Copy Markdown

❌ PR Check — Action Required

Check Status Details
📝 PR Description ❌ Fail Error: PR description must reference a JIRA ID, ISSUE ID, or a GitHub closing keyword.
Expected: include a JIRA ID / ISSUE ID line (separator : or -, or omitted; value may be a JIRA key, a number with/without #, or a link), OR a closing keyword + issue reference. Accepted examples:
JIRA ID : TESTAUTO-6039
JIRA ID - #330
JIRA ID #330
JIRA ID (on separate line)
ROCM-25757
ISSUE ID : TESTUTO-3334
ISSUE ID #3334
ISSUE ID - TESTAUTO-3433
ISSUE ID (on separate line)
AIRUNTIME-2352
ISSUE ID : https://github.com/<org_name>/<repo_name>/issues/1234
Closes #10
Fixes octo-org/octo-repo#100
Resolves: #123
#123
https://github.com/<org_name>/<repo_name>/issues/123
Current: no valid JIRA/ISSUE/closing-keyword reference found
Forbidden Files ✅ Pass
🧪 Unit Test ⚠️ Warning Error: Source/code files changed without an accompanying unit test.
Expected: add at least one test file named like test_<name>.py / test_<name>.cpp (or <name>_test.*).
Current: code file(s) changed: projects/hipblaslt/tensilelite/Tensile/Common/GlobalParameters.py, projects/hipblaslt/tensilelite/Tensile/Common/ValidParameters.py, projects/hipblaslt/tensilelite/Tensile/SolutionStructs/Solution.py; no test file found
🔎 pre-commit ✅ Pass
🚫 Draft PR 🔜 To Be Enabled
🚩 Feature Flag 🔜 To Be Enabled
📊 Code Coverage 🔜 To Be Enabled

⚠️ 1 policy check(s) failed. Please address the issues above before this PR can be Reviewed.

🚫 Please fix the failed policies

  • ❌ PR Description

The Not ready to Review label was added to this PR. Once all policies pass, the label is removed automatically.

📖 Need help? See the Policy FAQ for details on every check and how to fix failures.

🙋 Wish to Override Policy?

@therock-pr-bot

Copy link
Copy Markdown

🚫 Please fix the failed policies before requesting reviews.

The following policy checks failed:

  • ❌ PR Description

The Not ready to Review label has been added to this PR.
Once all policies pass, the label will be removed automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant