Skip to content

test(tensilelite): Add gfx1250_hw_xfail marker - #12178

Open
archana-ramalingam wants to merge 3 commits into
developfrom
users/aramalin/tensilelite-gfx1250-hw-xfail
Open

archana-ramalingam wants to merge 3 commits into
developfrom
users/aramalin/tensilelite-gfx1250-hw-xfail

Conversation

@archana-ramalingam

@archana-ramalingam archana-ramalingam commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

JIRA ID : AIHPBLAS-4510

Motivation

Technical Details

  • Add new gfx1250_hw_xfail marker
  • Yamls marked xfail only when GFX1250_HW_XFAIL is set AND running on gfx1250 HW
  • Active on per-PR workflow but inert on nightly

Test Plan

  • Unit tests in test_config_helpers.py: env-set→strict xfail, no-env→inert, other-arch→inert.

Test Result

  • pytest Tensile/Tests/common/test_config_helpers.py → 7 passed.

Submission Checklist

Risk level

  • Low — additive and env-gated; inert unless GFX1250_HW_XFAIL is set, so no change to FFM, unit, or nightly pipelines.

@therock-pr-bot

therock-pr-bot Bot commented Sep 16, 2026

Copy link
Copy Markdown

✅ All Checks Passed — Ready for Review

Check Status Details
📝 PR Description ✅ Pass
Forbidden Files ✅ Pass
🧪 Unit Test ✅ Pass
🔎 pre-commit ✅ Pass
🚫 Draft PR 🔜 To Be Enabled
🚩 Feature Flag 🔜 To Be Enabled
📊 Code Coverage 🔜 To Be Enabled
🤖 therock-pr-bot ✅ Pass

🎉 All checks passed! This PR is ready for review.

📖 Need help? See the Policy FAQ for details on every check and how to fix failures.

🙋 Wish to Override Policy?

@therock-pr-bot

Copy link
Copy Markdown

🎉 All checks passed! This PR is ready for review.

@codecov

codecov Bot commented Sep 16, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #12178   +/-   ##
========================================
  Coverage    70.29%   70.29%           
========================================
  Files         2812     2812           
  Lines       462769   462769           
  Branches     68122    68122           
========================================
  Hits        325271   325271           
  Misses      113943   113943           
  Partials     23555    23555           
Flag Coverage Δ *Carryforward flag
TensileLite-CPP 46.40% <ø> (ø)
TensileLite-Unit 76.10% <ø> (ø)
hipBLAS 90.62% <ø> (ø) Carriedforward from 4e41ad0
hipBLASLt 35.24% <ø> (ø) Carriedforward from 4e41ad0
hipCUB 82.68% <ø> (ø) Carriedforward from 4e41ad0
hipDNN 87.01% <ø> (ø) Carriedforward from 4e41ad0
hipFFT 43.07% <ø> (ø) Carriedforward from 4e41ad0
hipRAND 76.12% <ø> (ø) Carriedforward from 4e41ad0
hipSOLVER 68.92% <ø> (ø) Carriedforward from 4e41ad0
hipSPARSE 86.99% <ø> (ø) Carriedforward from 4e41ad0
rocBLAS 48.31% <ø> (ø) Carriedforward from 4e41ad0
rocFFT 47.88% <ø> (ø) Carriedforward from 4e41ad0
rocRAND 57.42% <ø> (ø) Carriedforward from 4e41ad0
rocSOLVER 76.83% <ø> (ø) Carriedforward from 4e41ad0
rocSPARSE 74.61% <ø> (ø) Carriedforward from 4e41ad0
rocThrust 91.60% <ø> (ø) Carriedforward from 4e41ad0

*This pull request uses carry forward flags. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@talumbau talumbau left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall this looks reasonable, but we just want simple 'xfail' on the tests that are still failing right now (no env variable checking). I spoke with Dhiraj - the nightly email infra will have to handle output of the form 'XFAILED' instead of just 'FAILED'. So we want one consistent handing of the tests between CI and nightly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants