test(tensilelite): Add gfx1250_hw_xfail marker - #12178
Open
archana-ramalingam wants to merge 3 commits into
Open
archana-ramalingam wants to merge 3 commits into
archana-ramalingam wants to merge 3 commits into
Conversation
✅ All Checks Passed — Ready for Review
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
|
🎉 All checks passed! This PR is ready for review. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #12178 +/- ##
========================================
Coverage 70.29% 70.29%
========================================
Files 2812 2812
Lines 462769 462769
Branches 68122 68122
========================================
Hits 325271 325271
Misses 113943 113943
Partials 23555 23555
*This pull request uses carry forward flags. Click here to find out more. 🚀 New features to boost your workflow:
|
talumbau
requested changes
Sep 16, 2026
Collaborator
There was a problem hiding this comment.
overall this looks reasonable, but we just want simple 'xfail' on the tests that are still failing right now (no env variable checking). I spoke with Dhiraj - the nightly email infra will have to handle output of the form 'XFAILED' instead of just 'FAILED'. So we want one consistent handing of the tests between CI and nightly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA ID : AIHPBLAS-4510
Motivation
Technical Details
gfx1250_hw_xfailmarkerGFX1250_HW_XFAILis set AND running on gfx1250 HWTest Plan
test_config_helpers.py: env-set→strict xfail, no-env→inert, other-arch→inert.Test Result
pytest Tensile/Tests/common/test_config_helpers.py→ 7 passed.Submission Checklist
Risk level