Conversation
Use the HIP package version already discovered by CMake for bundled Python commands so configured builds do not need hipconfig for version discovery. Keep the existing hipconfig fallback for standalone invocations and stop validating it as an independent compiler component during library creation.
github-actions
Bot
added
project: hipblaslt
project: hipsparselt
ci:hipsparselt-fast
labels
✅ All Checks Passed — Ready for Review
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
|
🎉 All checks passed! This PR is ready for review. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #12200 +/- ##
========================================
Coverage 70.34% 70.34%
========================================
Files 2812 2812
Lines 463054 463075 +21
Branches 68187 68191 +4
========================================
+ Hits 325706 325727 +21
Misses 113761 113761
Partials 23587 23587
*This pull request uses carry forward flags. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA ID: LCOMPILER-876
Related: #7235
Motivation
hipBLASLt discovers the HIP package during CMake configuration, including its version, but its bundled TensileLite commands currently discard that information. TensileLite consequently invokes
hipconfig --versionwhen its toolchain components are imported, andTensileCreateLibraryseparately validateshipconfigas an additional toolchain executable.For hipBLASLt builds, this is unnecessary: CMake has already selected the HIP installation and knows its version. Passing that version to TensileLite avoids depending on a separate legacy executable and ensures the compiler tools and version metadata come from the same configured HIP package.
Technical details
The hipBLASLt CMake configuration now passes
hip_VERSIONto bundled Python commands through theROCM_VERSIONenvironment variable. TensileLite prefers this explicit value when present and accepts ordinary, build-suffixed, and prerelease forms such as7.1.25424-4179531dcdand10.1.0a20260813.TensileCreateLibrarynow validates its four actual compiler components: the C++ compiler, C compiler, offload bundler, and assembler. It no longer performs a second, independent validation ofhipconfig.This change intentionally preserves standalone compatibility. TensileLite invocations that do not receive
ROCM_VERSIONcontinue to use the existinghipconfig --versionfallback. Standalone ROCm installation discovery and removal of that final fallback remain separate work.Testing
Focused TensileLite version-discovery and library-creation tests pass, including explicit-version precedence, prerelease parsing, invalid input, and the standalone
hipconfigfallback. A fresh hipBLASLt configuration confirmed that the selected HIP package version is embedded in bundled Python commands, and the corresponding minimal build completed successfully.