fix(hiptensor): Move benchmark tests off general ctests - #12202
Open
evedovelli wants to merge 2 commits into
Open
evedovelli wants to merge 2 commits into
evedovelli wants to merge 2 commits into
Conversation
✅ All Checks Passed — Ready for Review
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
|
🎉 All checks passed! This PR is ready for review. |
Ryker0627
reviewed
Sep 18, 2026
Ryker0627
left a comment
Contributor
There was a problem hiding this comment.
The changes are good. Worth notice that TESTING.md line 268 and test_categories.yaml line 91 need to update accordingly as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Running a bare ctest from the installed component dir (/bin/hiptensor) picked up every registered test — including the bench performance runs. Benchmarks are very slow (5 hot runs + 1 cold run per config, plus CPU-reference
validation on every shape), so a plain ctest intended for a quick functional check ended up dominated by benchmark timing loops. The goal is to keep bench out of the default ctest run while still allowing it to be invoked explicitly,
and to stop benchmarks wasting time on validation they don't need.
ISSUE ID : ROCM-30711
Technical Details
bin/hiptensor/CTestTestfile.cmake does not descend into it, a bare ctest there no longer runs the bench entries. They are opt-in via ctest from /bin/hiptensor/bench (or --test-dir).
Test Plan and Results
--cold_runs 1 and that the config -y path resolves.
Submission Checklist