Conversation
✅ All Checks Passed — Ready for Review
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
|
🎉 All checks passed! This PR is ready for review. |
newling
force-pushed
the
feature/host-numerics-bootstrap
branch
from
September 16, 2026 21:43
6383eca to
f5cd65d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is PR 1/N in a sequence introducing a shared host-numerics component.
The complete working prototype is available in draft PR #10553. That PR currently contains the end-to-end result and will remain open as a reference and integration test while its implementation is moved into
developthrough small, independently reviewable changes.The planned work has four broad phases:
The first three phases deliberately do not change any consumer. This keeps development isolated from hipBLASLt, TensileLite, and rocRoller behavior and allows each change to use a small, CPU-only GitHub Actions job. The target is for the component build and tests themselves to complete in under two minutes, excluding runner queue and provisioning time.
The endpoint demonstrated by #10553 is a large refactor of host-side data generation and numerical validation (
+51,927 / -63,657at the start of this series). It creates a standalone CPU-only shared component used by hipBLASLt, TensileLite, and rocRoller. It absorbs the reusable responsibilities currently provided bymxDataGenerator, allowing that package to be removed after its consumers migrate.This first PR intentionally contains almost no numerical functionality. It establishes the
roc::host-numerics-coreandroc::host-numericsCMake targets, an installableROCHostNumericsCMake package, an importableroc_host_numericsPython module, C++/Python/package smoke tests, a dedicated CPU-only GitHub Actions workflow, and initial ownership.Nothing in this PR is connected to an existing product or added to the default monorepo build.
Testing
Built and tested the standalone component with Clang and GCC. Verified the C++ target, Python import, installation, and an external
find_package(ROCHostNumerics)consumer. Repository pre-commit checks pass.