Skip to content

Commit ea6bb77

Browse files
committed
Qt: Fix image dimensions passed to camera_video_sink::present
1 parent 050d2d3 commit ea6bb77

2 files changed

Lines changed: 7 additions & 5 deletions

File tree

rpcs3/rpcs3qt/camera_settings_dialog.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -273,7 +273,7 @@ void camera_settings_dialog::handle_qt_camera_change(const QVariant& item_data)
273273
int index = 0;
274274
bool success = false;
275275
const std::string key = camera_info.id().toStdString();
276-
cfg_camera::camera_setting cfg_setting = g_cfg_camera.get_camera_setting(fmt::format("%s", camera_handler::qt), key, success);
276+
const cfg_camera::camera_setting cfg_setting = g_cfg_camera.get_camera_setting(fmt::format("%s", camera_handler::qt), key, success);
277277

278278
if (success)
279279
{

rpcs3/rpcs3qt/qt_camera_video_sink.cpp

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -34,20 +34,22 @@ bool qt_camera_video_sink::present(const QVideoFrame& frame)
3434
}
3535

3636
// Get image. This usually also converts the image to ARGB32.
37-
QImage image = frame.toImage();
38-
const u32 width = image.isNull() ? 0 : static_cast<u32>(image.width());
39-
const u32 height = image.isNull() ? 0 : static_cast<u32>(image.height());
37+
QImage image = tmp.toImage();
38+
u32 width = image.isNull() ? 0 : static_cast<u32>(image.width());
39+
u32 height = image.isNull() ? 0 : static_cast<u32>(image.height());
4040

4141
if (image.isNull())
4242
{
43-
camera_log.warning("Image is invalid: pixel_format=%s, format=%d", tmp.pixelFormat(), static_cast<int>(QVideoFrameFormat::imageFormatFromPixelFormat(tmp.pixelFormat())));
43+
camera_log.warning("Image is invalid: pixel_format=%s, format=%d", tmp.pixelFormat(), static_cast<s32>(QVideoFrameFormat::imageFormatFromPixelFormat(tmp.pixelFormat())));
4444
}
4545
else
4646
{
4747
// Scale image if necessary
4848
if (m_width > 0 && m_height > 0 && m_width != width && m_height != height)
4949
{
5050
image = image.scaled(m_width, m_height, Qt::AspectRatioMode::IgnoreAspectRatio, Qt::SmoothTransformation);
51+
width = static_cast<u32>(image.width());
52+
height = static_cast<u32>(image.height());
5153
}
5254

5355
// Determine image flip

0 commit comments

Comments
 (0)