Skip to content

RPCN: settings fixes - #18325

Merged
Megamouse merged 3 commits into
RPCS3:masterfrom
Megamouse:rpcn
Mar 10, 2026
Merged

RPCN: settings fixes#18325
Megamouse merged 3 commits into
RPCS3:masterfrom
Megamouse:rpcn

Conversation

@Megamouse

Copy link
Copy Markdown
Contributor
  • Fix segfault in rpcn settings dialog that happens when the dialog is closed without having properly initialized its rpcn object
  • Fix file access violation in rpcn_config when version is 1 and the file is adjusted. The file handle was still in use in that scope.
    This is a regression from @elad335 's additional file checks for windows. I'm not sure if this also causes other issues elsewhere.
  • Set rpcn default version to 2 (not sure why it's still 1)

This will happen if m_rpcn failed to connect in the constructor.
@Megamouse
Megamouse merged commit 9e573a9 into RPCS3:master Mar 10, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants