Add support to play from a BD Drive (currently only on Windows) - #18648
Conversation
| const std::string games_common_dir = g_cfg_vfs.get(g_cfg_vfs.games_dir, emu_dir); | ||
|
|
||
| if (make_path_verbose(games_common_dir, true)) | ||
| if (!is_iso_file(games_common_dir) && make_path_verbose(games_common_dir, true)) |
There was a problem hiding this comment.
I don't see a point in this
There was a problem hiding this comment.
otherwise a Fatal error (trying to write on a read only device) is logged. You can see it in current build simply setting a VFS games to a dvd drive.
Or eventually the log level could be converted to Error
There was a problem hiding this comment.
why would you do that? That's user error
There was a problem hiding this comment.
it's to provide dynamic scan (and the only available feature is based on VFS) also for BD drive. IMO, dynamic list is very useful (I basically use only that, so I can display some games instead of others). Of course, the Fatal error is not impacting the functionality (it will work without any issue). I simply suppressed that misleading error
ec2e4f1 to
5a571ba
Compare
digant73
changed the title
e313840 to
e15fe15
Compare
|
Is it possible to play games via bd drive on linux? |
not yet. I will work on it in few days but I will need testing from users due to I currently have not access to linux OS |
|
Hi! How is it going? Are you making any progress? On windows it works perfectly but I really want it to work also on my Steam Os. I really appreciate your hard work! Have a nice day :) |
please test PR #19233 and provide there any feedback |
Follow up of #18648 and #18345 adding BD Drive support to the remaining supported OSes. As it happens on Windows, both physical BD Drive and virtual drive (e.g. mounted `.iso` file) are supported. Code for mac OS and FreeBSD provided by AI. - key files need to be provided under `<rpcs3>/data/redump` folder (currently it needs to be manually created). This folder is also already the fallback folder for any encrypted ISO file Fixes #18345
4 participants
Follow up of #18345 to add support (currently only on
Windows; see notes below) for playing a PS3 disc game directly from a Blu-Ray Disc Drive.HOW IT WORKS:
VFS gamesor fromAdd Gamesmenu. In case it is selected fromVFS games, any attempt to write files is discarded, e.g. fileDisc Games Can Be Put Here For Automatic Detection.txt<rpcs3>/data/redump(it currently needs to be manually created due it is not yet provided by rpcs3 installation) to find a matching decryption keyNOTES:
Windowswhere I can fully test it. I cannot test under other OS. However, the additions needed for the other OS are limited only onfs::file.h/cpp. In particular inside the following new functions:bool is_optical_raw_device(const std::string& path);bool get_optical_raw_device(const std::string& path, std::string* raw_device = nullptr);mtimeon raw device is not available and any cache check would always fail)ISO.h/cppneeded some rework to properly manage a read on a raw device (alignment on offset, size and memory is mandatory). The BD drive needs to be detected as a file, not as a folderMINOR FIXES:
ISO.h/cpprelates to #18345 (not marked as
closesdue to currently supported only onWindows)