Skip to content

Some fixes - #18686

Merged
elad335 merged 5 commits into
RPCS3:masterfrom
digant73:some_fixes
May 7, 2026
Merged

Some fixes#18686
elad335 merged 5 commits into
RPCS3:masterfrom
digant73:some_fixes

Conversation

@digant73

@digant73 digant73 commented May 6, 2026

Copy link
Copy Markdown
Contributor

FIXES + MINOR IMPROVEMENTS:

  • Fixed ISO scanning changes broke previous folder-based games logic #18685: Not a real issue. PR Add support to play from a BD Drive (currently only on Windows) #18648 added some logging that made evident a missing check on the validity of the paths in games.yml before trying to manage the path as a possible ISO file. That missing check was already present but simply invisible due to missing log
  • Fixed bytes_to_hex() function used to store file hash hex string: In some cases the integrity check wrongly reported the check as failed
  • Optimized fs::get_optical_raw_device() function: Moved under _WIN32 block a check valid only on Windows and simplified the logic to detect a CDROM / BD as raw device
  • Used iso_file objects instead of fs:file in ISO.cpp: It allows to use proper bool() operator on some checks

fixes #18685

Comment thread rpcs3/Loader/ISO.cpp Outdated
Comment thread Utilities/File.cpp Outdated
Comment thread rpcs3/Crypto/utils.cpp
@elad335
elad335 merged commit 0262973 into RPCS3:master May 7, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ISO scanning changes broke previous folder-based games logic

3 participants